From 8788fd63952b50e4692efbf75a21bf0608e4c01c Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Mon, 20 Nov 2017 20:28:18 -0800 Subject: chromeec: Change the API for hostevent/wake masks to handle 64-bit ChromeEC is getting ready to bump up the hostevents and wake masks to 64-bits. The current commands to program hostevents/wake masks will still operate on 32-bits only. A new EC host command will be added to handle 64-bit hostevents/wake masks. In order to prevent individual callers in coreboot from worrying about 32-bit/64-bit, the same API provided by google/chromeec will be updated to accept 64-bit parameters and return 64-bit values. Internally, host command handlers will take care of masking these parameters/return values to appropriate 32-bit/64-bit values. BUG=b:69329196 Change-Id: If59f3f2b1a2aa5ce95883df3e72efc4a32de1190 Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/22551 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- src/ec/google/chromeec/smihandler.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/ec/google/chromeec/smihandler.c') diff --git a/src/ec/google/chromeec/smihandler.c b/src/ec/google/chromeec/smihandler.c index 60b4d15058..71f0d71b8e 100644 --- a/src/ec/google/chromeec/smihandler.c +++ b/src/ec/google/chromeec/smihandler.c @@ -57,7 +57,7 @@ static void clear_pending_events(void) ; } -void chromeec_smi_sleep(int slp_type, uint32_t s3_mask, uint32_t s5_mask) +void chromeec_smi_sleep(int slp_type, uint64_t s3_mask, uint64_t s5_mask) { switch (slp_type) { case ACPI_S3: @@ -78,8 +78,8 @@ void chromeec_smi_sleep(int slp_type, uint32_t s3_mask, uint32_t s5_mask) clear_pending_events(); } -void chromeec_smi_device_event_sleep(int slp_type, uint32_t s3_mask, - uint32_t s5_mask) +void chromeec_smi_device_event_sleep(int slp_type, uint64_t s3_mask, + uint64_t s5_mask) { switch (slp_type) { case ACPI_S3: @@ -96,7 +96,7 @@ void chromeec_smi_device_event_sleep(int slp_type, uint32_t s3_mask, google_chromeec_get_device_current_events(); } -void chromeec_smi_apmc(int apmc, uint32_t sci_mask, uint32_t smi_mask) +void chromeec_smi_apmc(int apmc, uint64_t sci_mask, uint64_t smi_mask) { switch (apmc) { case APM_CNT_ACPI_ENABLE: -- cgit v1.2.3