From 07841c2a2a930383dfd56d5adc966d0efaafec66 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Sat, 17 Aug 2019 15:14:38 +0300 Subject: src/ec: Drop __PRE_RAM__ and __SMM__ guards MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit For files built in ramstage and smm -classes, testing for !__PRE_RAM__ is redundant. All chip_operations are exluded with use of DEVTREE_EARLY in static devicetree, so garbage collection will take care of the !__SMM__ cases. Change-Id: Id7219848d6f5c41c4a9724a72204fa5ef9458e43 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/34940 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- src/ec/smsc/mec1308/ec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src/ec/smsc') diff --git a/src/ec/smsc/mec1308/ec.c b/src/ec/smsc/mec1308/ec.c index 83dd729825..c6e282a015 100644 --- a/src/ec/smsc/mec1308/ec.c +++ b/src/ec/smsc/mec1308/ec.c @@ -115,10 +115,9 @@ void ec_set_ports(u16 cmd_reg, u16 data_reg) ec_data_reg = data_reg; } -#if !defined(__PRE_RAM__) && !defined(__SMM__) static void mec1308_enable(struct device *dev) { - struct ec_smsc_mec1308_config *conf = dev->chip_info; + DEVTREE_CONST struct ec_smsc_mec1308_config *conf = dev->chip_info; if (conf->mailbox_port) { ec_cmd_reg = conf->mailbox_port; @@ -130,4 +129,3 @@ struct chip_operations ec_smsc_mec1308_ops = { CHIP_NAME("SMSC MEC1308 EC Mailbox Interface") .enable_dev = mec1308_enable }; -#endif -- cgit v1.2.3