From ae3fd34e0074da005c3fba471060965c14f3ec76 Mon Sep 17 00:00:00 2001 From: Lee Leahy Date: Tue, 7 Mar 2017 12:55:23 -0800 Subject: src/include: Add space after comma Fix the following error detected by checkpatch.pl: ERROR: space required after that ',' (ctx:VxV) TEST=Build and run on Galileo Gen2 Change-Id: I297bfc3d03dc95b471d3bb4b13803e81963841b5 Signed-off-by: Lee Leahy Reviewed-on: https://review.coreboot.org/18647 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- src/include/cpu/amd/model_fxx_rev.h | 2 +- src/include/cpu/cpu.h | 2 +- src/include/cpu/x86/lapic.h | 6 +++--- src/include/cpu/x86/lapic_def.h | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) (limited to 'src/include/cpu') diff --git a/src/include/cpu/amd/model_fxx_rev.h b/src/include/cpu/amd/model_fxx_rev.h index 6bb8b43c1c..e34b4ed649 100644 --- a/src/include/cpu/amd/model_fxx_rev.h +++ b/src/include/cpu/amd/model_fxx_rev.h @@ -80,7 +80,7 @@ static inline int is_e0_later_in_bsp(int nodeid) // d0 will be treated as e0 with this methods, but the d0 nb_cfg_54 always 0 pci_devfn_t dev; - dev = PCI_DEV(0, 0x18+nodeid,2); + dev = PCI_DEV(0, 0x18+nodeid, 2); val_old = pci_read_config32(dev, 0x80); val = val_old; val |= (1<<3); diff --git a/src/include/cpu/cpu.h b/src/include/cpu/cpu.h index dd89a8cc88..d5468549d7 100644 --- a/src/include/cpu/cpu.h +++ b/src/include/cpu/cpu.h @@ -10,7 +10,7 @@ void initialize_cpus(struct bus *cpu_bus); void asmlinkage secondary_cpu_init(unsigned int cpu_index); int cpu_phys_address_size(void); -#define __cpu_driver __attribute__ ((used,__section__(".rodata.cpu_driver"))) +#define __cpu_driver __attribute__ ((used, __section__(".rodata.cpu_driver"))) #ifndef __SIMPLE_DEVICE__ /** start of compile time generated pci driver array */ extern struct cpu_driver _cpu_drivers[]; diff --git a/src/include/cpu/x86/lapic.h b/src/include/cpu/x86/lapic.h index dfcb4da032..69a6738c8c 100644 --- a/src/include/cpu/x86/lapic.h +++ b/src/include/cpu/x86/lapic.h @@ -67,7 +67,7 @@ void stop_this_cpu(void); #if !defined(__PRE_RAM__) -#define xchg(ptr,v) ((__typeof__(*(ptr)))__xchg((unsigned long)(v),(ptr),sizeof(*(ptr)))) +#define xchg(ptr, v) ((__typeof__(*(ptr)))__xchg((unsigned long)(v), (ptr), sizeof(*(ptr)))) struct __xchg_dummy { unsigned long a[100]; }; #define __xg(x) ((struct __xchg_dummy *)(x)) @@ -111,11 +111,11 @@ static inline void lapic_write_atomic(unsigned long reg, unsigned long v) #ifdef X86_GOOD_APIC # define FORCE_READ_AROUND_WRITE 0 # define lapic_read_around(x) lapic_read(x) -# define lapic_write_around(x,y) lapic_write((x),(y)) +# define lapic_write_around(x, y) lapic_write((x), (y)) #else # define FORCE_READ_AROUND_WRITE 1 # define lapic_read_around(x) lapic_read(x) -# define lapic_write_around(x,y) lapic_write_atomic((x),(y)) +# define lapic_write_around(x, y) lapic_write_atomic((x), (y)) #endif static inline int lapic_remote_read(int apicid, int reg, unsigned long *pvalue) diff --git a/src/include/cpu/x86/lapic_def.h b/src/include/cpu/x86/lapic_def.h index 2b1ca5a13f..ec1ca6e359 100644 --- a/src/include/cpu/x86/lapic_def.h +++ b/src/include/cpu/x86/lapic_def.h @@ -75,7 +75,7 @@ #define LAPIC_DELIVERY_MODE_NMI (4<<8) #define LAPIC_DELIVERY_MODE_EXTINT (7<<8) #define GET_LAPIC_DELIVERY_MODE(x) (((x)>>8)&0x7) -#define SET_LAPIC_DELIVERY_MODE(x,y) (((x)&~0x700)|((y)<<8)) +#define SET_LAPIC_DELIVERY_MODE(x, y) (((x)&~0x700)|((y)<<8)) #define LAPIC_MODE_FIXED 0x0 #define LAPIC_MODE_NMI 0x4 #define LAPIC_MODE_EXINT 0x7 -- cgit v1.2.3