From 9ff8f6f818d4e5a8aa0fe21cbfaba9ccd865bc7b Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Mon, 23 Feb 2015 14:31:09 -0800 Subject: Unify byte order macros and clrsetbits This patch removes quite a bit of code duplication between cpu_to_le32() and clrsetbits_le32() style macros on the different architectures. This also syncs those macros back up to the new write32(a, v) style IO accessor macros that are now used on ARM and ARM64. CQ-DEPEND=CL:254862 BRANCH=none BUG=chromium:444723 TEST=Compiled Cosmos, Daisy, Blaze, Falco, Pinky, Pit, Rambi, Ryu, Storm and Urara. Booted on Jerry. Tried to compare binary images... unfortunately something about the new macro notation makes the compiler evaluate it more efficiently (not recalculating the address between the read and the write), so this was of limited value. Change-Id: If8ab62912c952d68a67a0f71e82b038732cd1317 Signed-off-by: Patrick Georgi Original-Commit-Id: fd43bf446581bfb84bec4f2ebb56b5de95971c3b Original-Change-Id: I7d301b5bb5ac0db7f5ff39e3adc2b28a1f402a72 Original-Signed-off-by: Julius Werner Original-Reviewed-on: https://chromium-review.googlesource.com/254866 Original-Reviewed-by: Aaron Durbin Reviewed-on: http://review.coreboot.org/9838 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer --- src/include/device/pci_rom.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/include/device') diff --git a/src/include/device/pci_rom.h b/src/include/device/pci_rom.h index a929206318..2fb2f7a8d5 100644 --- a/src/include/device/pci_rom.h +++ b/src/include/device/pci_rom.h @@ -1,6 +1,6 @@ #ifndef PCI_ROM_H #define PCI_ROM_H -#include +#include #include #define PCI_ROM_HDR 0xAA55 -- cgit v1.2.3