From 22c28e0f6aa6aa66828e575b552baf8fb23c3b82 Mon Sep 17 00:00:00 2001 From: Lee Leahy Date: Tue, 7 Mar 2017 15:47:44 -0800 Subject: src/include: Move storage class to beginning of declaration Fix the following warning detected by checkpatch.pl: WARNING: storage class should be at the beginning of the declaration The following storage class attribute is not detected by checkpatch.py: static cbmem_init_hook_t init_fn_ ## _ptr_ __attribute__((used, \ section(".rodata.cbmem_init_hooks"))) = init_fn_; The following lines generates a false positive: (pound)define STATIC static src/include/cpu/amd/common/cbtypes.h:60: WARNING: storage class should be at the beginning of the declaration typedef asmlinkage void (*smm_handler_t)(void *); src/include/cpu/x86/smm.h:514: WARNING: storage class should be at the beginning of the declaration (pound)define MAYBE_STATIC static src/include/stddef.h:34: WARNING: storage class should be at the beginning of the declaration TEST=Build and run on Galileo Gen2 Change-Id: Ie087d38e6171b549b90e0b831050ac44746a1e14 Signed-off-by: Lee Leahy Reviewed-on: https://review.coreboot.org/18657 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- src/include/thread.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/include/thread.h') diff --git a/src/include/thread.h b/src/include/thread.h index d2006359d5..586fb3afd0 100644 --- a/src/include/thread.h +++ b/src/include/thread.h @@ -65,7 +65,7 @@ static inline void thread_init_cpu_info_non_bsp(struct cpu_info *ci) } /* Architecture specific thread functions. */ -void asmlinkage switch_to_thread(uintptr_t new_stack, uintptr_t *saved_stack); +asmlinkage void switch_to_thread(uintptr_t new_stack, uintptr_t *saved_stack); /* Set up the stack frame for a new thread so that a switch_to_thread() call * will enter the thread_entry() function with arg as a parameter. The * saved_stack field in the struct thread needs to be updated accordingly. */ -- cgit v1.2.3