From a3b898aaf0ddf48fc3a577f4c39dd1d8acf31b6f Mon Sep 17 00:00:00 2001 From: David Hendricks Date: Sun, 2 Aug 2015 18:07:48 -0700 Subject: edid: Clean-up the edid struct There are serveral members of the edid struct which are never used outside of the EDID parsing code itself. This patch moves them to a struct in edid.c. They might be useful some day but until then we can just pretty print them and not pollute the more general API. BUG=none BRANCH=firmware-veyron TEST=compiled for veyron_mickey, peppy, link, nyan_big, rush, smaug Signed-off-by: David Hendricks Change-Id: I660f28c850163e89fe1f59d6c5cfd6e63a56dda0 Signed-off-by: Patrick Georgi Original-Commit-Id: ee8ea314a0d8f5993508f560fc24ab17604049df Original-Change-Id: I7fb8674619c0b780cc64f3ab786286225a3fe0e2 Original-Reviewed-on: https://chromium-review.googlesource.com/290333 Original-Reviewed-by: Yakir Yang Original-Reviewed-by: Julius Werner Original-Commit-Queue: David Hendricks Original-Tested-by: David Hendricks Reviewed-on: http://review.coreboot.org/11387 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer --- src/include/edid.h | 24 ------------------------ 1 file changed, 24 deletions(-) (limited to 'src/include') diff --git a/src/include/edid.h b/src/include/edid.h index f77517773d..1422c1e696 100644 --- a/src/include/edid.h +++ b/src/include/edid.h @@ -27,14 +27,6 @@ */ struct edid { - char manuf_name[4]; - unsigned int model; - unsigned int serial; - unsigned int year; - unsigned int week; - unsigned int version[2]; - unsigned int nonconformant; - unsigned int type; /* These next three things used to all be called bpp. * Merriment ensued. The identifier * 'bpp' is herewith banished from our @@ -56,17 +48,9 @@ struct edid { * all over the place. */ unsigned int panel_bits_per_pixel; - unsigned int xres; - unsigned int yres; - unsigned int voltage; - unsigned int sync; - unsigned int xsize_cm; - unsigned int ysize_cm; /* used to compute timing for graphics chips. */ unsigned char phsync; unsigned char pvsync; - unsigned int x_mm; - unsigned int y_mm; unsigned int pixel_clock; unsigned int link_clock; unsigned int ha; @@ -87,14 +71,6 @@ struct edid { u32 x_resolution; u32 y_resolution; u32 bytes_per_line; - /* it is unlikely we need these things. */ - /* if one of these is non-zero, use that one. */ - /* they're aspect * 10 to provide some additional resolution */ - unsigned int aspect_landscape; - unsigned int aspect_portrait; - const char *range_class; - const char *syncmethod; - const char *stereo; }; /* Defined in src/lib/edid.c */ -- cgit v1.2.3