From 36984d85e758bd7b280a835c5c6e5c68b10e82b6 Mon Sep 17 00:00:00 2001 From: Lee Leahy Date: Fri, 10 Mar 2017 17:56:44 -0800 Subject: src/lib: Clean up general issues found by checkpatch.pl Fix the following errors and warnings detected by checkpatch.pl: ERROR: Bad function definition - void init_timer() should probably be void init_timer(void) ERROR: Prefixing 0x with decimal output is defective WARNING: Comparisons should place the constant on the right side of the test WARNING: char * array declaration might be better as static const TEST=Build and run on Galileo Gen2 Change-Id: I9f618eea95e1f92fa34f4f89da27c0b16ae7f4ee Signed-off-by: Lee Leahy Reviewed-on: https://review.coreboot.org/18763 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- src/lib/tlcl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/lib/tlcl.c') diff --git a/src/lib/tlcl.c b/src/lib/tlcl.c index 34da816adc..49854cbdcb 100644 --- a/src/lib/tlcl.c +++ b/src/lib/tlcl.c @@ -86,7 +86,7 @@ static uint32_t tlcl_send_receive_no_retry(const uint8_t *request, result = tpm_send_receive(request, tpm_command_size(request), response, &response_length); - if (0 != result) { + if (result != 0) { /* Communication with TPM failed, so response is garbage */ VBDEBUG("TPM: command 0x%x send/receive failed: 0x%x\n", tpm_command_code(request), result); -- cgit v1.2.3