From 2d7825b0fce070f41ef35b7fdcf599550663dbe9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Sat, 2 Jun 2018 14:52:25 +0300 Subject: amdfam10: Fix mismatch of function declarations MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Callsite declared returning int, which makes more sense than u8 the motherboard side code defined the functions with. Change-Id: I8ee83aa2833408ad163c9011a076e08578f3ca6f Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/26774 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- src/mainboard/amd/bimini_fam10/mainboard.c | 5 ++--- src/mainboard/amd/mahogany_fam10/mainboard.c | 4 ++-- src/mainboard/amd/tilapia_fam10/mainboard.c | 4 ++-- 3 files changed, 6 insertions(+), 7 deletions(-) (limited to 'src/mainboard/amd') diff --git a/src/mainboard/amd/bimini_fam10/mainboard.c b/src/mainboard/amd/bimini_fam10/mainboard.c index 78529be48d..b6347ebc37 100644 --- a/src/mainboard/amd/bimini_fam10/mainboard.c +++ b/src/mainboard/amd/bimini_fam10/mainboard.c @@ -22,9 +22,8 @@ #include #include #include +#include "southbridge/amd/rs780/rs780.h" - -u8 is_dev3_present(void); void set_pcie_dereset(void); void set_pcie_reset(void); @@ -70,7 +69,7 @@ void set_pcie_reset(void) /* GPIO 50h reset PCIe slot */ } -u8 is_dev3_present(void) +int is_dev3_present(void) { return 0; } diff --git a/src/mainboard/amd/mahogany_fam10/mainboard.c b/src/mainboard/amd/mahogany_fam10/mainboard.c index a327284566..53a8290685 100644 --- a/src/mainboard/amd/mahogany_fam10/mainboard.c +++ b/src/mainboard/amd/mahogany_fam10/mainboard.c @@ -22,10 +22,10 @@ #include #include "southbridge/amd/sb700/sb700.h" #include "southbridge/amd/sb700/smbus.h" +#include "southbridge/amd/rs780/rs780.h" void set_pcie_dereset(void); void set_pcie_reset(void); -u8 is_dev3_present(void); /* * Mahogany uses GPIO 6 as PCIe slot reset, GPIO4 as GFX slot reset. We need to * pull it up before training the slot. @@ -85,7 +85,7 @@ static void get_ide_dma66(void) } #endif /* get_ide_dma66() */ -u8 is_dev3_present(void) +int is_dev3_present(void) { return 0; } diff --git a/src/mainboard/amd/tilapia_fam10/mainboard.c b/src/mainboard/amd/tilapia_fam10/mainboard.c index 28522a7fbd..e8a08a53c1 100644 --- a/src/mainboard/amd/tilapia_fam10/mainboard.c +++ b/src/mainboard/amd/tilapia_fam10/mainboard.c @@ -22,6 +22,7 @@ #include #include #include "southbridge/amd/sb700/smbus.h" +#include "southbridge/amd/rs780/rs780.h" #define ADT7461_ADDRESS 0x4C #define ARA_ADDRESS 0x0C /* Alert Response Address */ @@ -35,7 +36,6 @@ void set_pcie_dereset(void); void set_pcie_reset(void); -u8 is_dev3_present(void); void set_pcie_dereset() { @@ -91,7 +91,7 @@ void set_pcie_reset() /* * justify the dev3 is exist or not */ -u8 is_dev3_present(void) +int is_dev3_present(void) { u16 word; struct device *sm_dev; -- cgit v1.2.3