From af9e459d125060db89430e0138d86f46b5820d66 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Thu, 3 Jan 2019 11:38:53 +0200 Subject: amdfam10 boards: Drop array bus_rs780 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Values in the array are not used anywhere. Change-Id: I608b8c2e21bc515c56a27982815c1da43f3bb976 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/30637 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans Reviewed-by: Angel Pons --- src/mainboard/amd/bimini_fam10/get_bus_conf.c | 19 +------------------ src/mainboard/amd/mahogany_fam10/get_bus_conf.c | 15 +-------------- src/mainboard/amd/tilapia_fam10/get_bus_conf.c | 15 +-------------- 3 files changed, 3 insertions(+), 46 deletions(-) (limited to 'src/mainboard/amd') diff --git a/src/mainboard/amd/bimini_fam10/get_bus_conf.c b/src/mainboard/amd/bimini_fam10/get_bus_conf.c index 579ca7bbfe..76048190bb 100644 --- a/src/mainboard/amd/bimini_fam10/get_bus_conf.c +++ b/src/mainboard/amd/bimini_fam10/get_bus_conf.c @@ -23,7 +23,6 @@ /* Global variables for MB layouts and these will be shared by irqtable mptable * and acpi_tables busnum is default. */ -static u8 bus_rs780[11]; u8 bus_sb800[6]; u32 apicid_sb800; @@ -64,13 +63,7 @@ void get_bus_conf(void) memset(bus_sb800, 0, sizeof(bus_sb800)); - for (i = 0; i < ARRAY_SIZE(bus_rs780); i++) { - bus_rs780[i] = 0; - } - - - bus_rs780[0] = (sysconf.pci1234[0] >> 16) & 0xff; - bus_sb800[0] = bus_rs780[0]; + bus_sb800[0] = (sysconf.pci1234[0] >> 16) & 0xff; /* sb800 */ dev = dev_find_slot(bus_sb800[0], PCI_DEVFN(0x14, 4)); @@ -85,16 +78,6 @@ void get_bus_conf(void) } } - /* rs780 */ - for (i = 1; i < ARRAY_SIZE(bus_rs780); i++) { - dev = dev_find_slot(bus_rs780[0], PCI_DEVFN(sysconf.sbdn + i, 0)); - if (dev) { - bus_rs780[i] = pci_read_config8(dev, PCI_SECONDARY_BUS); - if(255 != bus_rs780[i]) { - } - } - } - /* I/O APICs: APIC ID Version State Address */ if (IS_ENABLED(CONFIG_LOGICAL_CPUS)) apicid_base = get_apicid_base(1); diff --git a/src/mainboard/amd/mahogany_fam10/get_bus_conf.c b/src/mainboard/amd/mahogany_fam10/get_bus_conf.c index 9812b00ae5..b97556c4b3 100644 --- a/src/mainboard/amd/mahogany_fam10/get_bus_conf.c +++ b/src/mainboard/amd/mahogany_fam10/get_bus_conf.c @@ -24,7 +24,6 @@ /* Global variables for MB layouts and these will be shared by irqtable mptable * and acpi_tables busnum is default. */ -static u8 bus_rs780[11]; u8 bus_sb700[2]; u32 apicid_sb700; @@ -65,12 +64,8 @@ void get_bus_conf(void) for (i = 0; i < 2; i++) { bus_sb700[i] = 0; } - for (i = 0; i < ARRAY_SIZE(bus_rs780); i++) { - bus_rs780[i] = 0; - } - bus_rs780[0] = (sysconf.pci1234[0] >> 16) & 0xff; - bus_sb700[0] = bus_rs780[0]; + bus_sb700[0] = (sysconf.pci1234[0] >> 16) & 0xff; /* sb700 */ dev = dev_find_slot(bus_sb700[0], PCI_DEVFN(0x14, 4)); @@ -78,14 +73,6 @@ void get_bus_conf(void) bus_sb700[1] = pci_read_config8(dev, PCI_SECONDARY_BUS); } - /* rs780 */ - for (i = 1; i < ARRAY_SIZE(bus_rs780); i++) { - dev = dev_find_slot(bus_rs780[0], PCI_DEVFN(sysconf.sbdn + i, 0)); - if (dev) { - bus_rs780[i] = pci_read_config8(dev, PCI_SECONDARY_BUS); - } - } - /* I/O APICs: APIC ID Version State Address */ if (IS_ENABLED(CONFIG_LOGICAL_CPUS)) apicid_base = get_apicid_base(1); diff --git a/src/mainboard/amd/tilapia_fam10/get_bus_conf.c b/src/mainboard/amd/tilapia_fam10/get_bus_conf.c index 9812b00ae5..b97556c4b3 100644 --- a/src/mainboard/amd/tilapia_fam10/get_bus_conf.c +++ b/src/mainboard/amd/tilapia_fam10/get_bus_conf.c @@ -24,7 +24,6 @@ /* Global variables for MB layouts and these will be shared by irqtable mptable * and acpi_tables busnum is default. */ -static u8 bus_rs780[11]; u8 bus_sb700[2]; u32 apicid_sb700; @@ -65,12 +64,8 @@ void get_bus_conf(void) for (i = 0; i < 2; i++) { bus_sb700[i] = 0; } - for (i = 0; i < ARRAY_SIZE(bus_rs780); i++) { - bus_rs780[i] = 0; - } - bus_rs780[0] = (sysconf.pci1234[0] >> 16) & 0xff; - bus_sb700[0] = bus_rs780[0]; + bus_sb700[0] = (sysconf.pci1234[0] >> 16) & 0xff; /* sb700 */ dev = dev_find_slot(bus_sb700[0], PCI_DEVFN(0x14, 4)); @@ -78,14 +73,6 @@ void get_bus_conf(void) bus_sb700[1] = pci_read_config8(dev, PCI_SECONDARY_BUS); } - /* rs780 */ - for (i = 1; i < ARRAY_SIZE(bus_rs780); i++) { - dev = dev_find_slot(bus_rs780[0], PCI_DEVFN(sysconf.sbdn + i, 0)); - if (dev) { - bus_rs780[i] = pci_read_config8(dev, PCI_SECONDARY_BUS); - } - } - /* I/O APICs: APIC ID Version State Address */ if (IS_ENABLED(CONFIG_LOGICAL_CPUS)) apicid_base = get_apicid_base(1); -- cgit v1.2.3