From 9c538348d8ccaef2c3dd6b898a1f44b00ea59690 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Tue, 12 Nov 2019 16:42:33 +0100 Subject: nb/intel/sandybridge: Make the mainboard_rcba_config hook optional This also changes the name to mainboard_late_rcba_config to better reflect what it does. This adds an empty weakly linked default. The rationale behind this change is that without an implementation of the hook some features might not work but that the result is likely still able to boot, so it can be made optional. Change-Id: I1897d0f5ca7427d304a425f5256cd43c088ff936 Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/36781 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/mainboard/asus/h61m-cs/romstage.c | 4 ---- src/mainboard/asus/maximus_iv_gene-z/romstage.c | 4 ---- src/mainboard/asus/p8h61-m_lx/romstage.c | 4 ---- src/mainboard/asus/p8h61-m_pro/romstage.c | 4 ---- src/mainboard/asus/p8z77-m_pro/romstage.c | 4 ---- 5 files changed, 20 deletions(-) (limited to 'src/mainboard/asus') diff --git a/src/mainboard/asus/h61m-cs/romstage.c b/src/mainboard/asus/h61m-cs/romstage.c index 37b07e51d9..4c8eda74fe 100644 --- a/src/mainboard/asus/h61m-cs/romstage.c +++ b/src/mainboard/asus/h61m-cs/romstage.c @@ -31,10 +31,6 @@ void pch_enable_lpc(void) { } -void mainboard_rcba_config(void) -{ -} - const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 0, 0 }, { 1, 0, 0 }, diff --git a/src/mainboard/asus/maximus_iv_gene-z/romstage.c b/src/mainboard/asus/maximus_iv_gene-z/romstage.c index 6cf206b47c..e29dd0f160 100644 --- a/src/mainboard/asus/maximus_iv_gene-z/romstage.c +++ b/src/mainboard/asus/maximus_iv_gene-z/romstage.c @@ -44,10 +44,6 @@ void pch_enable_lpc(void) { } -void mainboard_rcba_config(void) -{ -} - void mainboard_config_superio(void) { static const pnp_devfn_t GLOBAL_PSEUDO_DEV = PNP_DEV(0x2e, 0); diff --git a/src/mainboard/asus/p8h61-m_lx/romstage.c b/src/mainboard/asus/p8h61-m_lx/romstage.c index 5f94d17cf4..01ae6030ad 100644 --- a/src/mainboard/asus/p8h61-m_lx/romstage.c +++ b/src/mainboard/asus/p8h61-m_lx/romstage.c @@ -47,10 +47,6 @@ void pch_enable_lpc(void) CNF1_LPC_EN | KBC_LPC_EN | LPT_LPC_EN | COMA_LPC_EN); } -void mainboard_rcba_config(void) -{ -} - void mainboard_config_superio(void) { nuvoton_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE); diff --git a/src/mainboard/asus/p8h61-m_pro/romstage.c b/src/mainboard/asus/p8h61-m_pro/romstage.c index 60d311d98c..3736ab6b65 100644 --- a/src/mainboard/asus/p8h61-m_pro/romstage.c +++ b/src/mainboard/asus/p8h61-m_pro/romstage.c @@ -32,10 +32,6 @@ void pch_enable_lpc(void) KBC_LPC_EN | LPT_LPC_EN | COMA_LPC_EN); } -void mainboard_rcba_config(void) -{ -} - const struct southbridge_usb_port mainboard_usb_ports[] = { { 1, 0, 0 }, { 1, 0, 0 }, diff --git a/src/mainboard/asus/p8z77-m_pro/romstage.c b/src/mainboard/asus/p8z77-m_pro/romstage.c index db2d303e8c..5fff2e143c 100644 --- a/src/mainboard/asus/p8z77-m_pro/romstage.c +++ b/src/mainboard/asus/p8z77-m_pro/romstage.c @@ -34,10 +34,6 @@ void pch_enable_lpc(void) { } -void mainboard_rcba_config(void) -{ -} - const struct southbridge_usb_port mainboard_usb_ports[] = { /* {enable, current, oc_pin} */ { 1, 2, 0 }, /* Port 0: USB3 front internal header, top */ -- cgit v1.2.3