From 51c6d4429c65e01ac936de078482c4bab1a7a078 Mon Sep 17 00:00:00 2001 From: Wisley Chen Date: Wed, 8 Jul 2020 16:18:46 +0800 Subject: mb/google/hatch: Set SA slow slew rate to 1/2 for jinlon/dratini Screen flickered on VT2 on some devices after idle a period of time. Remove SSR (1/8) setting for SA to default SSR (1/2), screen flicking issue disappeared, and didn't affect acoustic noise much. Because CB:38212 (commit eae254e) caused this issue. BUG=b:160754994 TEST=build dratini, observe that screen flick issue disapppered Change-Id: I9e81c2f15dd6babfa360eee213fc4ab6310c7455 Signed-off-by: Wisley Chen Reviewed-on: https://review.coreboot.org/c/coreboot/+/43284 Reviewed-by: Paul Fagerburg Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) --- src/mainboard/google/hatch/variants/dratini/overridetree.cb | 1 - src/mainboard/google/hatch/variants/jinlon/overridetree.cb | 1 - 2 files changed, 2 deletions(-) (limited to 'src/mainboard/google/hatch/variants') diff --git a/src/mainboard/google/hatch/variants/dratini/overridetree.cb b/src/mainboard/google/hatch/variants/dratini/overridetree.cb index 0bada7d916..2bfcc26c89 100644 --- a/src/mainboard/google/hatch/variants/dratini/overridetree.cb +++ b/src/mainboard/google/hatch/variants/dratini/overridetree.cb @@ -23,7 +23,6 @@ chip soc/intel/cannonlake register "AcousticNoiseMitigation" = "1" register "SlowSlewRateForIa" = "2" register "SlowSlewRateForGt" = "2" - register "SlowSlewRateForSa" = "2" register "FastPkgCRampDisableIa" = "1" register "FastPkgCRampDisableGt" = "1" register "FastPkgCRampDisableSa" = "1" diff --git a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb index a3bb782a36..fc3bb854b0 100644 --- a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb +++ b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb @@ -23,7 +23,6 @@ chip soc/intel/cannonlake register "AcousticNoiseMitigation" = "1" register "SlowSlewRateForIa" = "2" register "SlowSlewRateForGt" = "2" - register "SlowSlewRateForSa" = "2" register "FastPkgCRampDisableIa" = "1" register "FastPkgCRampDisableGt" = "1" register "FastPkgCRampDisableSa" = "1" -- cgit v1.2.3