From 79cc577ba241582a36fa138904fbcde7473437e1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Sun, 10 Feb 2019 16:38:30 +0200 Subject: google/kahlee: Remove unneeded HAVE_ACPI_RESUME guard MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We leave it to linker garbage collection to drop unreferenced code and symbols from final object files. Function declarations and definitions are to be guarded with preprocessor directives only as a last resort. Change-Id: Ie8748ccddc8e31569c58deba5d08c98a04326fa8 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/31317 Tested-by: build bot (Jenkins) Reviewed-by: Richard Spiegel Reviewed-by: Marshall Dawson --- src/mainboard/google/kahlee/mainboard.c | 4 ---- 1 file changed, 4 deletions(-) (limited to 'src/mainboard/google/kahlee/mainboard.c') diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c index ebdcc935e9..ed48593282 100644 --- a/src/mainboard/google/kahlee/mainboard.c +++ b/src/mainboard/google/kahlee/mainboard.c @@ -195,12 +195,10 @@ int mainboard_get_ehci_oc_map(uint16_t *map) return variant_get_ehci_oc_map(map); } -#if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME) void mainboard_suspend_resume(void) { variant_mainboard_suspend_resume(); } -#endif struct chip_operations mainboard_ops = { .init = mainboard_init, @@ -214,11 +212,9 @@ uint8_t __weak variant_board_sku(void) return 0; } -#if IS_ENABLED(CONFIG_HAVE_ACPI_RESUME) void __weak variant_mainboard_suspend_resume(void) { } -#endif const char *smbios_mainboard_sku(void) { -- cgit v1.2.3