From 883de54fed25aebe3e68418adc63e7d54b400f91 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Thu, 11 Jan 2018 14:12:58 -0800 Subject: mainboard/google/kahlee: Fix GPIO table The GPIOs that are being set low had the wrong value getting set. FCH_GPIO_OUTPUT_VALUE was being set instead of FCH_GPIO_OUTPUT_ENABLE. BUG=b:70234300 TEST=Build and boot Grunt Change-Id: I16792b76252506a43aac92738b04096ae3fde01c Signed-off-by: Martin Roth Reviewed-on: https://review.coreboot.org/23224 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin Reviewed-by: Paul Menzel Reviewed-by: Richard Spiegel --- src/mainboard/google/kahlee/variants/baseboard/gpio.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/mainboard/google/kahlee/variants') diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c index 250fcc106e..58d9473218 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c +++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c @@ -112,7 +112,7 @@ static const GPIO_CONTROL agesa_board_gpios[] = { { GPIO_42, Function0, FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE }, /* GPIO_67 - PEN_RESET */ - { GPIO_67, Function0, FCH_GPIO_OUTPUT_VALUE }, + { GPIO_67, Function0, FCH_GPIO_OUTPUT_ENABLE }, /* GPIO_70 - WLAN_PE_RST_L */ { GPIO_70, Function0, FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE }, @@ -127,10 +127,10 @@ static const GPIO_CONTROL agesa_board_gpios[] = { { GPIO_76, Function0, FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE }, /* GPIO_84 - HUB_RST (Active High) */ - { GPIO_84, Function1, FCH_GPIO_OUTPUT_VALUE }, + { GPIO_84, Function1, FCH_GPIO_OUTPUT_ENABLE }, /* GPIO_85 - TOUCHSCREEN_RST (Active High) */ - { GPIO_85, Function1, FCH_GPIO_OUTPUT_VALUE }, + { GPIO_85, Function1, FCH_GPIO_OUTPUT_ENABLE }, /* GPIO_86 - Unused (TP109) */ { GPIO_86, Function1, FCH_GPIO_PULL_UP_ENABLE }, @@ -208,7 +208,7 @@ static const GPIO_CONTROL agesa_board_gpios[] = { { GPIO_132, Function2, }, /* GPIO_133 - APU_EDP_BKLTEN_L (backlight - Active LOW) */ - { GPIO_133, Function1, FCH_GPIO_OUTPUT_VALUE }, + { GPIO_133, Function1, FCH_GPIO_OUTPUT_ENABLE }, /* GPIO_135 - Unused (TP128) */ { GPIO_135, Function1, FCH_GPIO_PULL_UP_ENABLE }, -- cgit v1.2.3