From 97278939fff8c7c572a373f3f7a515be193785bd Mon Sep 17 00:00:00 2001 From: YH Lin Date: Tue, 26 Feb 2019 09:33:50 -0800 Subject: flapjack: use sku_id 0 for un-provisioned board Instead of using 2, 0 is now used for non-CBI provisioned board or corrupted CBI board to confrom to the sku encoding. BUG=b:123676982 BRANCH=kukui TEST=test with un-provisioned board to verify the sku_id. Signed-off-by: YH Lin Change-Id: I66f29f8a46cd774b40354def7d3623ec44cb96ce Reviewed-on: https://review.coreboot.org/c/31623 Tested-by: build bot (Jenkins) Reviewed-by: Daisuke Nojiri Reviewed-by: Patrick Georgi --- src/mainboard/google/kukui/boardid.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/mainboard/google/kukui/boardid.c') diff --git a/src/mainboard/google/kukui/boardid.c b/src/mainboard/google/kukui/boardid.c index 2af93c8a0a..b1d6736262 100644 --- a/src/mainboard/google/kukui/boardid.c +++ b/src/mainboard/google/kukui/boardid.c @@ -19,7 +19,8 @@ #include #include -#define FLAPJACK_UNDEF_SKU_ID 2 /* For all un-provisioned Flapjack boards */ +/* For CBI un-provisioned/corrupted Flapjack board. */ +#define FLAPJACK_UNDEF_SKU_ID 0 static uint32_t get_index(unsigned int channel, uint32_t *cached_id) { @@ -67,7 +68,7 @@ uint32_t sku_id(void) { static uint32_t cached_sku_id = BOARD_ID_INIT; - /* On Flapjack, getting the SKU via CBI */ + /* On Flapjack, getting the SKU via CBI. */ if (IS_ENABLED(CONFIG_BOARD_GOOGLE_FLAPJACK)) { if (cached_sku_id == BOARD_ID_INIT && google_chromeec_cbi_get_sku_id(&cached_sku_id)) -- cgit v1.2.3