From 6c2c018e15a1c4d3ae394333263e6c7c3eb30415 Mon Sep 17 00:00:00 2001 From: Peter Lemenkov Date: Mon, 21 Oct 2019 21:42:17 +0200 Subject: mb/*/*/acpi_tables: Remove unnecessary function call Remove acpi_update_thermal_table local function. Change-Id: I4857348088feb8eaf1dd7f553c4efb29da8943cf Signed-off-by: Peter Lemenkov Reviewed-on: https://review.coreboot.org/c/coreboot/+/36212 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- src/mainboard/google/link/acpi_tables.c | 29 ++++++++++++----------------- 1 file changed, 12 insertions(+), 17 deletions(-) (limited to 'src/mainboard/google/link') diff --git a/src/mainboard/google/link/acpi_tables.c b/src/mainboard/google/link/acpi_tables.c index 0ff4364574..891151a4cb 100644 --- a/src/mainboard/google/link/acpi_tables.c +++ b/src/mainboard/google/link/acpi_tables.c @@ -19,22 +19,6 @@ #include #include "thermal.h" -static void acpi_update_thermal_table(global_nvs_t *gnvs) -{ - gnvs->tmps = CTDP_SENSOR_ID; - - gnvs->f1of = CTDP_NOMINAL_THRESHOLD_OFF; - gnvs->f1on = CTDP_NOMINAL_THRESHOLD_ON; - - gnvs->f0of = CTDP_DOWN_THRESHOLD_OFF; - gnvs->f0on = CTDP_DOWN_THRESHOLD_ON; - - gnvs->tcrt = CRITICAL_TEMPERATURE; - gnvs->tpsv = PASSIVE_TEMPERATURE; - gnvs->tmax = MAX_TEMPERATURE; - gnvs->flvl = 1; -} - void acpi_create_gnvs(global_nvs_t *gnvs) { /* Disable USB ports in S3 by default */ @@ -50,7 +34,18 @@ void acpi_create_gnvs(global_nvs_t *gnvs) ACTIVE_ECFW_RO : ACTIVE_ECFW_RW; #endif - acpi_update_thermal_table(gnvs); + gnvs->tmps = CTDP_SENSOR_ID; + + gnvs->f1of = CTDP_NOMINAL_THRESHOLD_OFF; + gnvs->f1on = CTDP_NOMINAL_THRESHOLD_ON; + + gnvs->f0of = CTDP_DOWN_THRESHOLD_OFF; + gnvs->f0on = CTDP_DOWN_THRESHOLD_ON; + + gnvs->tcrt = CRITICAL_TEMPERATURE; + gnvs->tpsv = PASSIVE_TEMPERATURE; + gnvs->tmax = MAX_TEMPERATURE; + gnvs->flvl = 1; // the lid is open by default. gnvs->lids = 1; -- cgit v1.2.3