From f7b5955b363034c7235ea6a5fcc399eaf53120ce Mon Sep 17 00:00:00 2001 From: Zhuohao Lee Date: Sat, 17 Mar 2018 05:00:49 +0800 Subject: mb/google/poppy/variants/nami: change type of board_sku_id() to uint32_t Tools/scripts, like mosys/arc-setup, use int (4 bytes) to read the sku id. In order to support "-1", we need to use uint32_t (4 bytes) instead of using uint16_t (2 bytes) data type. Otherwise, tools/scripts will read 65535 instead of -1. Another reason to change this is that sku_id can be supported by ec up to 4 bytes. BUG=b:73792190 TEST=mosys output "Platform not supported" for -1 sku id arc-setup read -1 sku id Change-Id: Ib3baa8419f138abeb412ac09c2e7dc608e3b758b Signed-off-by: Zhuohao Lee Reviewed-on: https://review.coreboot.org/25252 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh --- .../google/poppy/variants/baseboard/include/baseboard/variants.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/mainboard/google/poppy/variants/baseboard') diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h index e8a9b47ad1..97cb0fef2e 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h @@ -53,7 +53,7 @@ struct memory_params { void variant_memory_params(struct memory_params *p); int variant_memory_sku(void); void variant_devtree_update(void); -uint16_t variant_board_sku(void); +uint32_t variant_board_sku(void); struct nhlt; void variant_nhlt_init(struct nhlt *nhlt); -- cgit v1.2.3