From 0b9896f328d3c07f9f9db697d1a8fcde25200e00 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Thu, 4 Oct 2018 12:55:25 -0600 Subject: mb/google/kahlee: Don't set stapm parameters Setting the stapm parameters is causing S3 resume failures and performance issues. Removing these settings until more testing is done and the issues are solved. BUG=b:117252463, b:116870267 TEST=boot grunt Change-Id: I2299ab81fcc2af0529bfac3be562b05116c64a49 Signed-off-by: Martin Roth Reviewed-on: https://review.coreboot.org/28925 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel Reviewed-by: Richard Spiegel --- src/mainboard/google/kahlee/variants/careena/devicetree.cb | 8 +++++--- src/mainboard/google/kahlee/variants/grunt/devicetree.cb | 8 +++++--- 2 files changed, 10 insertions(+), 6 deletions(-) (limited to 'src/mainboard/google') diff --git a/src/mainboard/google/kahlee/variants/careena/devicetree.cb b/src/mainboard/google/kahlee/variants/careena/devicetree.cb index eb2acb9bdf..08d4d4d085 100644 --- a/src/mainboard/google/kahlee/variants/careena/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/careena/devicetree.cb @@ -20,9 +20,11 @@ chip soc/amd/stoneyridge register "dram_clear_on_reset" = "DRAM_CONTENTS_KEEP" register "uma_mode" = "UMAMODE_SPECIFIED_SIZE" register "uma_size" = "32 * MiB" - register "stapm_percent" = "68" - register "stapm_time" = "2500" - register "stapm_power" = "7800" + + # Don't set STAPM values for now + # register "stapm_percent" = "68" + # register "stapm_time" = "2500" + # register "stapm_power" = "7800" # Enable I2C0 for audio, USB3 hub at 400kHz register "i2c[0]" = "{ diff --git a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb index 228ead2854..128de7d5fc 100644 --- a/src/mainboard/google/kahlee/variants/grunt/devicetree.cb +++ b/src/mainboard/google/kahlee/variants/grunt/devicetree.cb @@ -20,9 +20,11 @@ chip soc/amd/stoneyridge register "dram_clear_on_reset" = "DRAM_CONTENTS_KEEP" register "uma_mode" = "UMAMODE_SPECIFIED_SIZE" register "uma_size" = "32 * MiB" - register "stapm_percent" = "80" - register "stapm_time" = "2500" - register "stapm_power" = "7800" + + # For now, don't set STAPM values + # register "stapm_percent" = "80" + # register "stapm_time" = "2500" + # register "stapm_power" = "7800" # Enable I2C0 for audio, USB3 hub at 400kHz register "i2c[0]" = "{ -- cgit v1.2.3