From 15ddb363d4d869fa1c3512e7fbf9682ec41375bf Mon Sep 17 00:00:00 2001 From: Raul E Rangel Date: Mon, 26 Apr 2021 09:43:36 -0600 Subject: mb/google/guybrush: Fix EC SCI configuration This change fixes two problems: 1) We had the enum values for .direction and .level swapped. The naming is very confusing... 2) ESPI_SYS is not a good event to use for EC SCI. It is a level/low event that is only cleared by reading the eSPI status register 0x9C. Cezanne has added a new event source that directly exposes the SCI bit. This is the correct event source to use for EC SCI. BUG=b:186045622, b:181139095 TEST=`lpc sci` on EC console and see /proc/interrupts increase by 1 Signed-off-by: Raul E Rangel Change-Id: I764b9ec202376d5124331a320767cbf79371dc07 Reviewed-on: https://review.coreboot.org/c/coreboot/+/52673 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth Reviewed-by: Karthik Ramasubramanian Reviewed-by: Felix Held --- src/mainboard/google/guybrush/ec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/mainboard/google') diff --git a/src/mainboard/google/guybrush/ec.c b/src/mainboard/google/guybrush/ec.c index 5a0bc1b3c5..67fdda1428 100644 --- a/src/mainboard/google/guybrush/ec.c +++ b/src/mainboard/google/guybrush/ec.c @@ -9,10 +9,10 @@ static const struct sci_source espi_sci_sources[] = { { - .scimap = SMITYPE_ESPI_SYS, + .scimap = SMITYPE_ESPI_SCI_B, .gpe = EC_SCI_GPI, - .direction = SMI_SCI_LVL, - .level = SMI_SCI_LVL_HIGH + .direction = SMI_SCI_LVL_HIGH, /* enum smi_sci_lvl */ + .level = SMI_SCI_EDG, /* enum smi_sci_dir */ } }; -- cgit v1.2.3