From 6481cfb15d62784b87eabe972a742fa1e3da129d Mon Sep 17 00:00:00 2001 From: "Ronald G. Minnich" Date: Tue, 17 Dec 2013 15:21:54 -0800 Subject: peppy and falco: set panel power timings in northbridge, using devicetree, not mainboards Historically we had set panel timing in the mainboard gma code. This goes back to the replay-attack video startup. We can let the haswell gma code set these values from the device tree settings. Change-Id: If32150d2857241ca2d2c88880086f49d25815d76 Signed-off-by: Ronald G. Minnich Reviewed-on: https://chromium-review.googlesource.com/180521 Reviewed-by: Aaron Durbin Commit-Queue: Ronald Minnich Tested-by: Ronald Minnich (cherry picked from commit 406eab3ca6a9bc59382866817786bf96bbb19d56) Signed-off-by: Isaac Christensen Reviewed-on: http://review.coreboot.org/6911 Tested-by: build bot (Jenkins) Reviewed-by: Ronald G. Minnich --- src/mainboard/google/falco/gma.c | 3 --- src/mainboard/google/peppy/gma.c | 5 ----- 2 files changed, 8 deletions(-) (limited to 'src/mainboard/google') diff --git a/src/mainboard/google/falco/gma.c b/src/mainboard/google/falco/gma.c index 4a5b7d03f3..6e3afdbf34 100644 --- a/src/mainboard/google/falco/gma.c +++ b/src/mainboard/google/falco/gma.c @@ -188,9 +188,6 @@ int panel_lightup(struct intel_dp *dp, unsigned int init_fb) /* These values are used for training the link */ dp->lane_count = 2; dp->link_bw = DP_LINK_BW_2_7; - dp->panel_power_down_delay = 600; - dp->panel_power_up_delay = 200; - dp->panel_power_cycle_delay = 600; dp->pipe = PIPE_A; dp->port = PORT_A; dp->plane = PLANE_A; diff --git a/src/mainboard/google/peppy/gma.c b/src/mainboard/google/peppy/gma.c index 0e954e0a3b..953dad9a09 100644 --- a/src/mainboard/google/peppy/gma.c +++ b/src/mainboard/google/peppy/gma.c @@ -214,11 +214,6 @@ int panel_lightup(struct intel_dp *dp, unsigned int init_fb) dp->aux_clock_divider = 0xe1; dp->precharge = 3; - /* CRAP -- needs to be done elsewhere from the device tree. */ - dp->panel_power_down_delay = 600; - dp->panel_power_up_delay = 200; - dp->panel_power_cycle_delay = 600; - /* 1. Normal mode: Set the first page to zero and make all GTT entries point to the same page 2. Developer/Recovery mode: Set up a tasteful color -- cgit v1.2.3