From b32816e9a5564e3604c3829b92727b54356f4777 Mon Sep 17 00:00:00 2001 From: Vladimir Serbinenko Date: Fri, 20 Dec 2013 17:47:19 +0100 Subject: Remove PCI_ROM_RUN option The main purpose of option rom is to supply int* handlers. But supplying those is outside of coreboot scope and if someone needs those they should run SeaBIOS anyway which runs the option roms wonderfully. Running VGA oprom is kept because they're needed to init graphics. This patch still keeps the options to include the option roms to make them available to SeaBIOS. Change-Id: I646334cf88094d3bf8f527779a68a07e0b4b93ec Signed-off-by: Vladimir Serbinenko Reviewed-on: http://review.coreboot.org/4545 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi Reviewed-by: Kevin O'Connor --- src/mainboard/google/bolt/mainboard.c | 6 +++--- src/mainboard/google/butterfly/mainboard.c | 6 +++--- src/mainboard/google/falco/mainboard.c | 6 +++--- src/mainboard/google/link/mainboard.c | 6 +++--- src/mainboard/google/parrot/mainboard.c | 6 +++--- src/mainboard/google/peppy/mainboard.c | 6 +++--- src/mainboard/google/slippy/mainboard.c | 6 +++--- src/mainboard/google/stout/mainboard.c | 6 +++--- 8 files changed, 24 insertions(+), 24 deletions(-) (limited to 'src/mainboard/google') diff --git a/src/mainboard/google/bolt/mainboard.c b/src/mainboard/google/bolt/mainboard.c index 3bf26e3f21..d4213017cc 100644 --- a/src/mainboard/google/bolt/mainboard.c +++ b/src/mainboard/google/bolt/mainboard.c @@ -26,7 +26,7 @@ #include #include #include -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN #include #endif #include @@ -45,7 +45,7 @@ void mainboard_suspend_resume(void) outb(0xcb, 0xb2); } -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN static int int15_handler(void) { int res = 0; @@ -189,7 +189,7 @@ static void mainboard_enable(device_t dev) { dev->ops->init = mainboard_init; dev->ops->get_smbios_data = mainboard_smbios_data; -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN /* Install custom int15 handler for VGA OPROM */ mainboard_interrupt_handlers(0x15, &int15_handler); #endif diff --git a/src/mainboard/google/butterfly/mainboard.c b/src/mainboard/google/butterfly/mainboard.c index eb7d363c9c..1623fe01c6 100644 --- a/src/mainboard/google/butterfly/mainboard.c +++ b/src/mainboard/google/butterfly/mainboard.c @@ -24,7 +24,7 @@ #include #include #include -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN #include #endif #include @@ -195,7 +195,7 @@ void mainboard_suspend_resume(void) outb(0xcb, 0xb2); } -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN static int int15_handler(void) { int res = 0; @@ -381,7 +381,7 @@ static void mainboard_enable(device_t dev) { dev->ops->init = mainboard_init; dev->ops->get_smbios_data = butterfly_onboard_smbios_data; -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN /* Install custom int15 handler for VGA OPROM */ mainboard_interrupt_handlers(0x15, &int15_handler); #endif diff --git a/src/mainboard/google/falco/mainboard.c b/src/mainboard/google/falco/mainboard.c index 3bf26e3f21..d4213017cc 100644 --- a/src/mainboard/google/falco/mainboard.c +++ b/src/mainboard/google/falco/mainboard.c @@ -26,7 +26,7 @@ #include #include #include -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN #include #endif #include @@ -45,7 +45,7 @@ void mainboard_suspend_resume(void) outb(0xcb, 0xb2); } -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN static int int15_handler(void) { int res = 0; @@ -189,7 +189,7 @@ static void mainboard_enable(device_t dev) { dev->ops->init = mainboard_init; dev->ops->get_smbios_data = mainboard_smbios_data; -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN /* Install custom int15 handler for VGA OPROM */ mainboard_interrupt_handlers(0x15, &int15_handler); #endif diff --git a/src/mainboard/google/link/mainboard.c b/src/mainboard/google/link/mainboard.c index 08b1c02a96..9c63acd182 100644 --- a/src/mainboard/google/link/mainboard.c +++ b/src/mainboard/google/link/mainboard.c @@ -25,7 +25,7 @@ #include #include #include -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN #include #endif #include @@ -61,7 +61,7 @@ void mainboard_suspend_resume(void) outb(0xcb, 0xb2); } -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN static int int15_handler(void) { int res = 0; @@ -222,7 +222,7 @@ static void mainboard_enable(device_t dev) { dev->ops->init = mainboard_init; dev->ops->get_smbios_data = link_onboard_smbios_data; -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN /* Install custom int15 handler for VGA OPROM */ mainboard_interrupt_handlers(0x15, &int15_handler); #endif diff --git a/src/mainboard/google/parrot/mainboard.c b/src/mainboard/google/parrot/mainboard.c index 34cb24e87e..56a1b47b63 100644 --- a/src/mainboard/google/parrot/mainboard.c +++ b/src/mainboard/google/parrot/mainboard.c @@ -24,7 +24,7 @@ #include #include #include -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN #include #endif #include @@ -49,7 +49,7 @@ void mainboard_suspend_resume(void) outb(0xe1, 0xb2); } -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN static int int15_handler(void) { int res = 0; @@ -191,7 +191,7 @@ static void mainboard_enable(device_t dev) { dev->ops->init = mainboard_init; dev->ops->get_smbios_data = parrot_onboard_smbios_data; -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN /* Install custom int15 handler for VGA OPROM */ mainboard_interrupt_handlers(0x15, &int15_handler); #endif diff --git a/src/mainboard/google/peppy/mainboard.c b/src/mainboard/google/peppy/mainboard.c index 3bf26e3f21..d4213017cc 100644 --- a/src/mainboard/google/peppy/mainboard.c +++ b/src/mainboard/google/peppy/mainboard.c @@ -26,7 +26,7 @@ #include #include #include -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN #include #endif #include @@ -45,7 +45,7 @@ void mainboard_suspend_resume(void) outb(0xcb, 0xb2); } -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN static int int15_handler(void) { int res = 0; @@ -189,7 +189,7 @@ static void mainboard_enable(device_t dev) { dev->ops->init = mainboard_init; dev->ops->get_smbios_data = mainboard_smbios_data; -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN /* Install custom int15 handler for VGA OPROM */ mainboard_interrupt_handlers(0x15, &int15_handler); #endif diff --git a/src/mainboard/google/slippy/mainboard.c b/src/mainboard/google/slippy/mainboard.c index 3bf26e3f21..d4213017cc 100644 --- a/src/mainboard/google/slippy/mainboard.c +++ b/src/mainboard/google/slippy/mainboard.c @@ -26,7 +26,7 @@ #include #include #include -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN #include #endif #include @@ -45,7 +45,7 @@ void mainboard_suspend_resume(void) outb(0xcb, 0xb2); } -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN static int int15_handler(void) { int res = 0; @@ -189,7 +189,7 @@ static void mainboard_enable(device_t dev) { dev->ops->init = mainboard_init; dev->ops->get_smbios_data = mainboard_smbios_data; -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN /* Install custom int15 handler for VGA OPROM */ mainboard_interrupt_handlers(0x15, &int15_handler); #endif diff --git a/src/mainboard/google/stout/mainboard.c b/src/mainboard/google/stout/mainboard.c index 7f6b7ddd07..8cd2fbd8c0 100644 --- a/src/mainboard/google/stout/mainboard.c +++ b/src/mainboard/google/stout/mainboard.c @@ -24,7 +24,7 @@ #include #include #include -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN #include #endif #include @@ -49,7 +49,7 @@ void mainboard_suspend_resume(void) ec_write_cmd(EC_CMD_NOTIFY_ACPI_ENTER); } -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN static int int15_handler(void) { int res = 0; @@ -174,7 +174,7 @@ static void mainboard_init(device_t dev) static void mainboard_enable(device_t dev) { dev->ops->init = mainboard_init; -#if CONFIG_PCI_ROM_RUN || CONFIG_VGA_ROM_RUN +#if CONFIG_VGA_ROM_RUN /* Install custom int15 handler for VGA OPROM */ mainboard_interrupt_handlers(0x15, &int15_handler); #endif -- cgit v1.2.3