From 9f7f92c7eedcddfde5800223a23d076a5e148a0e Mon Sep 17 00:00:00 2001 From: Paul Menzel Date: Mon, 27 Apr 2020 13:55:47 +0200 Subject: amd/agesa/hudson boards: Get rid of power button device Port commit d7b88dcb (mb/google/x86-boards: Get rid of power button device in coreboot) to AMD AGESA Hudson boards. No idea, if this is correct for the two laptops. The Lenovo G505s also incorrectly defines two power buttons. [ 0.911423] input: Power Button as /devices/LNXSYSTM:00/LNXSYBUS:00/PNP0C0C:00/input/input1 [ 0.911434] ACPI: Power Button [PWRB] [ 0.911493] input: Power Button as /devices/LNXSYSTM:00/LNXPWRBN:00/input/input2 [ 0.912326] ACPI: Power Button [PWRF] If the generic power button device is needed, the POWER_BUTTON flag should be set in FADT. The GPE ACPI code seems to originate from commit 806def8c (I missed the svn add on r3787. These are the additional files., Add AMD dbm690t ACPI support.), and was copied over. Change-Id: I88950e15faf1b90ca6e688864bac40bf9779c32e Signed-off-by: Paul Menzel Reviewed-on: https://review.coreboot.org/c/coreboot/+/40754 Tested-by: build bot (Jenkins) Reviewed-by: Mike Banon --- src/mainboard/hp/pavilion_m6_1035dx/acpi/gpe.asl | 2 -- src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl | 6 ------ 2 files changed, 8 deletions(-) (limited to 'src/mainboard/hp/pavilion_m6_1035dx') diff --git a/src/mainboard/hp/pavilion_m6_1035dx/acpi/gpe.asl b/src/mainboard/hp/pavilion_m6_1035dx/acpi/gpe.asl index 36d84b3592..1e15d7a37d 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/acpi/gpe.asl +++ b/src/mainboard/hp/pavilion_m6_1035dx/acpi/gpe.asl @@ -23,7 +23,6 @@ Scope(\_GPE) { /* Start Scope GPE */ Notify(\_SB.PCI0.UOH4, 0x02) Notify(\_SB.PCI0.XHC0, 0x02) Notify(\_SB.PCI0.UEH1, 0x02) - Notify(\_SB.PWRB, 0x02) } /* ExtEvent0 SCI event */ @@ -58,6 +57,5 @@ Scope(\_GPE) { /* Start Scope GPE */ Method(_L1B) { /* DBGO("\\_GPE\\_L1B\n") */ Notify(\_SB.PCI0.AZHD, 0x02) /* NOTIFY_DEVICE_WAKE */ - Notify(\_SB.PWRB, 0x02) /* NOTIFY_DEVICE_WAKE */ } } /* End Scope GPE */ diff --git a/src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl b/src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl index 059794ec30..dd3318e3cc 100644 --- a/src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl +++ b/src/mainboard/hp/pavilion_m6_1035dx/acpi/mainboard.asl @@ -79,12 +79,6 @@ Scope (\_SB) { } } - Device(PWRB) { - Name(_HID, EisaId("PNP0C0C")) - Name(_UID, 0xAA) - Name(_STA, 0x0B) - } - Device (MB) { Name(_HID, EisaId("PNP0C01")) // System Board -- cgit v1.2.3