From a4ab665a556da24929ec1537901b38fbe9f4252b Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Mon, 25 Sep 2017 08:06:56 -0700 Subject: mb/google/*: Use newly added Chrome EC boardid function Instead of duplicating code across multiple mainboards, use newly added helper function to read boardid from Chrome EC. Change-Id: I1671c0a0b87d0c4c45da5340e8f17a4a798317ca Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/21682 Tested-by: build bot (Jenkins) Reviewed-by: Sumeet R Pawnikar Reviewed-by: Aaron Durbin --- src/mainboard/intel/strago/Kconfig | 1 + src/mainboard/intel/strago/Makefile.inc | 2 -- src/mainboard/intel/strago/boardid.c | 30 ------------------------------ 3 files changed, 1 insertion(+), 32 deletions(-) delete mode 100644 src/mainboard/intel/strago/boardid.c (limited to 'src/mainboard/intel/strago') diff --git a/src/mainboard/intel/strago/Kconfig b/src/mainboard/intel/strago/Kconfig index 44ca249dc9..bef0e63c78 100644 --- a/src/mainboard/intel/strago/Kconfig +++ b/src/mainboard/intel/strago/Kconfig @@ -4,6 +4,7 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 select EC_GOOGLE_CHROMEEC + select EC_GOOGLE_CHROMEEC_BOARDID select EC_GOOGLE_CHROMEEC_MEC select EC_GOOGLE_CHROMEEC_ACPI_MEMMAP select ENABLE_BUILTIN_COM1 diff --git a/src/mainboard/intel/strago/Makefile.inc b/src/mainboard/intel/strago/Makefile.inc index 5ba7bcce8d..bbef8b956e 100644 --- a/src/mainboard/intel/strago/Makefile.inc +++ b/src/mainboard/intel/strago/Makefile.inc @@ -14,11 +14,9 @@ ## GNU General Public License for more details. ## -romstage-y += boardid.c romstage-$(CONFIG_MAINBOARD_HAS_CHROMEOS) += chromeos.c romstage-$(CONFIG_ENABLE_BUILTIN_COM1) += com_init.c -ramstage-y += boardid.c ramstage-$(CONFIG_MAINBOARD_HAS_CHROMEOS) += chromeos.c ramstage-$(CONFIG_MAINBOARD_HAS_CHROMEOS) += ec.c ramstage-$(CONFIG_MAINBOARD_HAS_CHROMEOS) += gpio.c diff --git a/src/mainboard/intel/strago/boardid.c b/src/mainboard/intel/strago/boardid.c deleted file mode 100644 index b531778531..0000000000 --- a/src/mainboard/intel/strago/boardid.c +++ /dev/null @@ -1,30 +0,0 @@ -/* - * This file is part of the coreboot project. - * - * Copyright(C) 2013 Google Inc. - * Copyright (C) 2015 Intel Corp. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - */ - -#include -#include -#include "ec/google/chromeec/ec.h" - -uint8_t board_id(void) -{ - MAYBE_STATIC int id = -1; - -#if IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC) - if (id < 0) - id = google_chromeec_get_board_version(); -#endif - return id; -} -- cgit v1.2.3