From df27690df354169309970cfe5ebd292d2bf9ab3d Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Mon, 18 Sep 2017 18:21:02 +0200 Subject: mb/lenovo/x2?0/devicetree: Fix regression of BDC detection MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The x220 and x230 do have BDC detection, but it's broken. Disable BDC detection on those two boards, and add a comment why it doesn't work. The issue has been reported and tested on Lenovo X220. Change-Id: Id1ccc2c4387370e284ff8964e1c41d945cefe74c Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/21587 Tested-by: build bot (Jenkins) Reviewed-by: Jonathan Neuschäfer Reviewed-by: Arthur Heymans Reviewed-by: Paul Menzel --- src/mainboard/lenovo/x220/devicetree.cb | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'src/mainboard/lenovo/x220') diff --git a/src/mainboard/lenovo/x220/devicetree.cb b/src/mainboard/lenovo/x220/devicetree.cb index 1332cd8548..ae2a03ec09 100644 --- a/src/mainboard/lenovo/x220/devicetree.cb +++ b/src/mainboard/lenovo/x220/devicetree.cb @@ -165,9 +165,11 @@ chip northbridge/intel/sandybridge register "eventd_enable" = "0xff" register "evente_enable" = "0x0d" - register "has_bdc_detection" = "1" - register "bdc_gpio_num" = "54" - register "bdc_gpio_lvl" = "0" + # BDC detection is broken on this board: + # BDC shorts pin14 and pin1 + # BDC's connector pin14 is left floating + # BDC's connector pin1 is routed to SB GPIO 54 + register "has_bdc_detection" = "0" end end # LPC bridge device pci 1f.2 on -- cgit v1.2.3