From 98adaf5989845f7859054f5cee2cf1f4e0392640 Mon Sep 17 00:00:00 2001 From: Paul Menzel Date: Fri, 17 Mar 2017 12:15:14 +0100 Subject: =?UTF-8?q?mainboards:=20Don=E2=80=99t=20select=20`CONSOLE=5FPOST`?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently, it’s impossible for the user to select `NO_POST`, for boards selecting `CONSOLE_POST` in their config. ``` warning: (BOARD_SPECIFIC_OPTIONS) selects CONSOLE_POST which has unmet direct dependencies (VENDOR_SIEMENS && BOARD_SIEMENS_MC_BDX1 || !NO_POST) ``` This is currently done for Intel Camelback Mountain and Siemens MC-BDX1. Selecting the option `CONSOLE_POST` in board specific configuration is not a good idea, as this should be user configurable over Kconfig, and also the tree-wide defaults should be the same for these options. Kconfig is different, as commit 97535558f1 (mainboard/{google,intel}: Change config option selection) only touch the Intel board. Change-Id: I91c1e0cb92ed218b6bbc7c33759b91f748cf6f51 Signed-off-by: Paul Menzel Reviewed-on: https://review.coreboot.org/18878 Tested-by: build bot (Jenkins) Reviewed-by: Werner Zeh --- src/mainboard/siemens/mc_bdx1/Kconfig | 4 ---- 1 file changed, 4 deletions(-) (limited to 'src/mainboard/siemens') diff --git a/src/mainboard/siemens/mc_bdx1/Kconfig b/src/mainboard/siemens/mc_bdx1/Kconfig index e679eb590d..f64b22bf09 100644 --- a/src/mainboard/siemens/mc_bdx1/Kconfig +++ b/src/mainboard/siemens/mc_bdx1/Kconfig @@ -38,10 +38,6 @@ config VIRTUAL_ROM_SIZE hex default 0x1000000 -config CONSOLE_POST - bool - default y - config INTEGRATED_UART bool default n -- cgit v1.2.3