From 773485b8920145443da8b09712553c10c954fed1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Mon, 22 Dec 2014 16:33:24 +0200 Subject: intel CAR: Fix DCACHE_RAM_BASE for old sockets MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When using fixed MTRRs for CAR setup, CONFIG_DCACHE_RAM_BASE is ignored and was not correctly set on affected sockets and boards. It was still referenced in romstage linker script. This was discovered by clang builds failing for cases where DCACHE_RAM_BASE = 0, while gcc builds passed. The actual DCACHE_RAM_BASE programming is base = 0xd0000 - size, as taken from intel/cpu/cache_as_ram.inc. Change-Id: Ied5ab2e9683f12990f1aad48ee15eaf91133121c Signed-off-by: Kyösti Mälkki Reviewed-on: http://review.coreboot.org/7887 Tested-by: build bot (Jenkins) Reviewed-by: Edward O'Callaghan --- src/mainboard/digitallogic/adl855pc/Kconfig | 8 -------- src/mainboard/intel/mtarvon/Kconfig | 8 -------- src/mainboard/lanner/em8510/Kconfig | 8 -------- src/mainboard/rca/rm4100/Kconfig | 8 -------- src/mainboard/thomson/ip1000/Kconfig | 8 -------- 5 files changed, 40 deletions(-) (limited to 'src/mainboard') diff --git a/src/mainboard/digitallogic/adl855pc/Kconfig b/src/mainboard/digitallogic/adl855pc/Kconfig index 8c57a89e89..d8cb4b2557 100644 --- a/src/mainboard/digitallogic/adl855pc/Kconfig +++ b/src/mainboard/digitallogic/adl855pc/Kconfig @@ -18,14 +18,6 @@ config MAINBOARD_PART_NUMBER string default "smartModule855" -config DCACHE_RAM_BASE - hex - default 0xffdf8000 - -config DCACHE_RAM_SIZE - hex - default 0x8000 - config IRQ_SLOT_COUNT int default 5 diff --git a/src/mainboard/intel/mtarvon/Kconfig b/src/mainboard/intel/mtarvon/Kconfig index 4097fa7a23..75bca403f2 100644 --- a/src/mainboard/intel/mtarvon/Kconfig +++ b/src/mainboard/intel/mtarvon/Kconfig @@ -23,14 +23,6 @@ config IRQ_SLOT_COUNT int default 1 -config DCACHE_RAM_BASE - hex - default 0xffdf8000 - -config DCACHE_RAM_SIZE - hex - default 0x8000 - config MAX_CPUS int default 4 diff --git a/src/mainboard/lanner/em8510/Kconfig b/src/mainboard/lanner/em8510/Kconfig index e042e81b4e..2919df9d25 100644 --- a/src/mainboard/lanner/em8510/Kconfig +++ b/src/mainboard/lanner/em8510/Kconfig @@ -18,14 +18,6 @@ config MAINBOARD_PART_NUMBER string default "EM-8510" -config DCACHE_RAM_BASE - hex - default 0xffdf8000 - -config DCACHE_RAM_SIZE - hex - default 0x8000 - config IRQ_SLOT_COUNT int default 10 diff --git a/src/mainboard/rca/rm4100/Kconfig b/src/mainboard/rca/rm4100/Kconfig index 8f0450521c..a6f216eec1 100644 --- a/src/mainboard/rca/rm4100/Kconfig +++ b/src/mainboard/rca/rm4100/Kconfig @@ -18,14 +18,6 @@ config MAINBOARD_PART_NUMBER string default "RM4100" -config DCACHE_RAM_BASE - hex - default 0xffdf8000 - -config DCACHE_RAM_SIZE - hex - default 0x8000 - config IRQ_SLOT_COUNT int default 7 diff --git a/src/mainboard/thomson/ip1000/Kconfig b/src/mainboard/thomson/ip1000/Kconfig index 80d365c533..f775e2bd38 100644 --- a/src/mainboard/thomson/ip1000/Kconfig +++ b/src/mainboard/thomson/ip1000/Kconfig @@ -19,14 +19,6 @@ config MAINBOARD_PART_NUMBER string default "IP1000" -config DCACHE_RAM_BASE - hex - default 0xffdf8000 - -config DCACHE_RAM_SIZE - hex - default 0x8000 - config IRQ_SLOT_COUNT int default 7 -- cgit v1.2.3