From deeccbf4e96de1cd4ed136f865b96a90db374886 Mon Sep 17 00:00:00 2001 From: Elyes HAOUAS Date: Sat, 4 Apr 2020 12:26:35 +0200 Subject: Drop explicit NULL initializations from `device_operations` Unmentioned fields are initialized with 0 (or NULL) implicitly. Beside that, the struct has grown over the years. There are too many optional fields to list them all. Change-Id: Icb9e14c58153d7c14817bcde148e86e977666e4b Signed-off-by: Elyes HAOUAS Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/coreboot/+/40126 Reviewed-by: Angel Pons Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) --- src/mainboard/emulation/qemu-i440fx/mainboard.c | 1 - src/mainboard/emulation/qemu-i440fx/northbridge.c | 2 -- src/mainboard/emulation/qemu-q35/mainboard.c | 1 - 3 files changed, 4 deletions(-) (limited to 'src/mainboard') diff --git a/src/mainboard/emulation/qemu-i440fx/mainboard.c b/src/mainboard/emulation/qemu-i440fx/mainboard.c index 5e9b3208c6..751035ec34 100644 --- a/src/mainboard/emulation/qemu-i440fx/mainboard.c +++ b/src/mainboard/emulation/qemu-i440fx/mainboard.c @@ -36,7 +36,6 @@ static struct device_operations nb_operations = { .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = qemu_nb_init, - .ops_pci = 0, }; static const struct pci_driver nb_driver __pci_driver = { diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c index 38ab9df71b..e5df0168c0 100644 --- a/src/mainboard/emulation/qemu-i440fx/northbridge.c +++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c @@ -236,8 +236,6 @@ static const char *qemu_acpi_name(const struct device *dev) static struct device_operations pci_domain_ops = { .read_resources = cpu_pci_domain_read_resources, .set_resources = cpu_pci_domain_set_resources, - .enable_resources = NULL, - .init = NULL, .scan_bus = pci_domain_scan_bus, #if CONFIG(GENERATE_SMBIOS_TABLES) .get_smbios_data = qemu_get_smbios_data, diff --git a/src/mainboard/emulation/qemu-q35/mainboard.c b/src/mainboard/emulation/qemu-q35/mainboard.c index 6bb99cd24d..460864aac1 100644 --- a/src/mainboard/emulation/qemu-q35/mainboard.c +++ b/src/mainboard/emulation/qemu-q35/mainboard.c @@ -55,7 +55,6 @@ static struct device_operations nb_operations = { .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, .init = qemu_nb_init, - .ops_pci = 0, }; static const struct pci_driver nb_driver __pci_driver = { -- cgit v1.2.3