From 27c4edace6ff3246c6b0345300931850d9e7f4bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Tue, 21 Oct 2014 14:19:04 +0300 Subject: AGESA: Report events with AGESA_EVENTLOG() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit NOTE: For fam12 and fam14 ASSERT() is defined empty so execution may fall through critical failures. Change-Id: Ifef65d749d340f1df3a43b5fcb38c4315ef944e8 Signed-off-by: Kyösti Mälkki Reviewed-on: http://review.coreboot.org/7154 Reviewed-by: Edward O'Callaghan Tested-by: build bot (Jenkins) --- src/northbridge/amd/agesa/agesawrapper.h | 1 + src/northbridge/amd/agesa/agesawrapper_call.h | 9 +++++++++ 2 files changed, 10 insertions(+) (limited to 'src/northbridge/amd') diff --git a/src/northbridge/amd/agesa/agesawrapper.h b/src/northbridge/amd/agesa/agesawrapper.h index 72c967383c..b18f43da25 100644 --- a/src/northbridge/amd/agesa/agesawrapper.h +++ b/src/northbridge/amd/agesa/agesawrapper.h @@ -23,6 +23,7 @@ #include #include "Porting.h" #include "AGESA.h" +#include /* Define AMD Ontario APPU SSID/SVID */ #define AMD_APU_SVID 0x1022 diff --git a/src/northbridge/amd/agesa/agesawrapper_call.h b/src/northbridge/amd/agesa/agesawrapper_call.h index 792c3b1c05..0ddeb766fc 100644 --- a/src/northbridge/amd/agesa/agesawrapper_call.h +++ b/src/northbridge/amd/agesa/agesawrapper_call.h @@ -59,4 +59,13 @@ static inline u32 do_agesawrapper(AGESA_STATUS (*func)(void), const char *name) #define AGESAWRAPPER_PRE_CONSOLE(func) agesawrapper_ ## func() +#if CONFIG_NORTHBRIDGE_AMD_AGESA_FAMILY12 || CONFIG_NORTHBRIDGE_AMD_AGESA_FAMILY14 || CONFIG_BOARD_AMD_DINAR + /* TODO: These families do not pass valid HeapStatus. */ +#define AGESA_EVENTLOG(status) \ + if (status != AGESA_SUCCESS) agesawrapper_amdreadeventlog() +#else +#define AGESA_EVENTLOG(status, heapstatus) \ + if (status != AGESA_SUCCESS) agesawrapper_amdreadeventlog(heapstatus) +#endif + #endif -- cgit v1.2.3