From 30fbb4c23e7b867c707d61520c05cc4c6c17e174 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Mon, 20 Oct 2014 07:04:55 +0300 Subject: AGESA boards: Fix early agesawrapper_amdinitmmio() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Regression introduced with commit 7b23ae0 AGESA: Trace execution with AGESAWRAPPER() As the call is made before console_init() is called it must not call any printk(). Debugging Olivehill and Parmer platforms using a custom FPGA (as these boards have no Super-IO UART) have been observed to halt and/or delay at early boot. Change-Id: I3ab4e5378db44aece9046c8636cde1053ce5390d Signed-off-by: Kyösti Mälkki Reviewed-on: http://review.coreboot.org/7059 Reviewed-by: Edward O'Callaghan Tested-by: build bot (Jenkins) Reviewed-by: WANG Siyuan --- src/northbridge/amd/agesa/agesawrapper_call.h | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/northbridge/amd') diff --git a/src/northbridge/amd/agesa/agesawrapper_call.h b/src/northbridge/amd/agesa/agesawrapper_call.h index 0acbeee75f..792c3b1c05 100644 --- a/src/northbridge/amd/agesa/agesawrapper_call.h +++ b/src/northbridge/amd/agesa/agesawrapper_call.h @@ -57,4 +57,6 @@ static inline u32 do_agesawrapper(AGESA_STATUS (*func)(void), const char *name) #define AGESAWRAPPER(func) do_agesawrapper(agesawrapper_ ## func, #func) +#define AGESAWRAPPER_PRE_CONSOLE(func) agesawrapper_ ## func() + #endif -- cgit v1.2.3