From d1141ab5a49980de0d7da23879ce6ddf238471af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Tue, 7 Jan 2020 11:16:35 +0200 Subject: intel/e7505,i82801dx: Refactor raminit MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Avoid direct enable_smbus() call from northbridge code. Change-Id: I077e455242db9fc0f86432bd1afab75cb6fb6f4c Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/38267 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- src/northbridge/intel/e7505/raminit.c | 46 +++++++++++++++++++++-------------- 1 file changed, 28 insertions(+), 18 deletions(-) (limited to 'src/northbridge/intel/e7505/raminit.c') diff --git a/src/northbridge/intel/e7505/raminit.c b/src/northbridge/intel/e7505/raminit.c index 972a2f37ee..7953aca3b1 100644 --- a/src/northbridge/intel/e7505/raminit.c +++ b/src/northbridge/intel/e7505/raminit.c @@ -1740,28 +1740,38 @@ static void sdram_set_registers(const struct mem_controller *ctrl) d060_control(D060_CMD_1); } -/** - * - * - */ -void e7505_mch_init(const struct mem_controller *memctrl) +static int e7505_mch_is_ready(void) { - timestamp_add_now(TS_BEFORE_INITRAM); - - sdram_set_registers(memctrl); - sdram_set_spd_registers(memctrl); - sdram_enable(memctrl); + uint32_t dword = pci_read_config32(MCHDEV, DRC); + return !!(dword & DRC_DONE); } -void e7505_mch_done(const struct mem_controller *memctrl) +void sdram_initialize(void) { - sdram_post_ecc(memctrl); + static const struct mem_controller memctrl[] = { + { + .d0 = PCI_DEV(0, 0, 0), + .d0f1 = PCI_DEV(0, 0, 1), + .channel0 = { 0x50, 0x52, 0, 0 }, + .channel1 = { 0x51, 0x53, 0, 0 }, + }, + }; - timestamp_add_now(TS_AFTER_INITRAM); -} + /* If this is a warm boot, some initialisation can be skipped */ + if (!e7505_mch_is_ready()) { -int e7505_mch_is_ready(void) -{ - uint32_t dword = pci_read_config32(MCHDEV, DRC); - return !!(dword & DRC_DONE); + /* The real MCH initialisation. */ + timestamp_add_now(TS_BEFORE_INITRAM); + + sdram_set_registers(memctrl); + sdram_set_spd_registers(memctrl); + sdram_enable(memctrl); + + /* Hook for post ECC scrub settings and debug. */ + sdram_post_ecc(memctrl); + + timestamp_add_now(TS_AFTER_INITRAM); + } + + printk(BIOS_DEBUG, "SDRAM is up.\n"); } -- cgit v1.2.3