From 15b83da39a90ebfcc85ca3d18325ab00e8d3a26c Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Sat, 12 Jan 2019 15:05:20 +0100 Subject: nb/intel/x4x: Remove spurious pcidev_on_root() usage MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It's supposed to be the same device that is passed to the executing function. Change-Id: I6cf994390c16e0393c96a2b2e04a36305be88e68 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/30880 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki --- src/northbridge/intel/x4x/gma.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'src/northbridge/intel/x4x') diff --git a/src/northbridge/intel/x4x/gma.c b/src/northbridge/intel/x4x/gma.c index 680b83698b..4c27634955 100644 --- a/src/northbridge/intel/x4x/gma.c +++ b/src/northbridge/intel/x4x/gma.c @@ -60,7 +60,6 @@ void gma_set_gnvs_aslb(void *gnvs, uintptr_t aslb) static void gma_func0_init(struct device *dev) { - u16 reg16; u32 reg32; /* IGD needs to be Bus Master */ @@ -69,10 +68,7 @@ static void gma_func0_init(struct device *dev) pci_write_config32(dev, PCI_COMMAND, reg32); /* configure GMBUSFREQ */ - reg16 = pci_read_config16(pcidev_on_root(0x2, 0), 0xcc); - reg16 &= ~0x1ff; - reg16 |= 0xbc; - pci_write_config16(pcidev_on_root(0x2, 0), 0xcc, reg16); + pci_update_config16(dev, 0xcc, ~0x1ff, 0xbc); int vga_disable = (pci_read_config16(dev, D0F0_GGC) & 2) >> 1; -- cgit v1.2.3