From 616f394d3656760deb1e048c0dde4fe3aaa6607f Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Tue, 10 Dec 2013 17:12:44 -0800 Subject: baytrail: utilize reg_script_run_on_dev() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The inclusion of reg_script_run_on_dev() allows for removing some of the chained reg_scripts just to set up the device context. Use the new reg_script function in those cases. BUG=None BRANCH=None TEST=Built and booted. Didn't see any bizarre dmesg or coreboot console output. Change-Id: I3207449424c1efe92186125004d5aea1bb5ba438 Signed-off-by: Aaron Durbin Reviewed-on: https://chromium-review.googlesource.com/179541 Tested-by: Aaron Durbin Reviewed-by: Duncan Laurie Commit-Queue: Aaron Durbin Reviewed-on: http://review.coreboot.org/5009 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki --- src/soc/intel/baytrail/emmc.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) (limited to 'src/soc/intel/baytrail/emmc.c') diff --git a/src/soc/intel/baytrail/emmc.c b/src/soc/intel/baytrail/emmc.c index 0a7e9b18dd..a724c4a3f7 100644 --- a/src/soc/intel/baytrail/emmc.c +++ b/src/soc/intel/baytrail/emmc.c @@ -52,16 +52,11 @@ static const struct reg_script emmc_ops[] = { static void emmc_init(device_t dev) { struct soc_intel_baytrail_config *config = dev->chip_info; - struct reg_script ops[] = { - REG_SCRIPT_SET_DEV(dev), - REG_SCRIPT_NEXT(emmc_ops), - REG_SCRIPT_END, - }; - printk(BIOS_DEBUG, "eMMC init\n"); - reg_script_run(ops); if (config->scc_acpi_mode) scc_enable_acpi_mode(dev, SCC_MMC_CTL, SCC_NVS_MMC); + printk(BIOS_DEBUG, "eMMC init\n"); + reg_script_run_on_dev(dev, emmc_ops); } static struct device_operations device_ops = { -- cgit v1.2.3