From e47132be6601bfd485076d6520e56a8b8ecb0737 Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Mon, 23 Mar 2020 01:33:23 +0100 Subject: intel/broadwell: Correct backlight-PWM divider The PWM-granularity chicken bit in the Wildcat Point and Lynx Point PCHs has actually the opposite meaning of the one for Sunrise Point and later. When the bit is set, we get a divider of 16, when it's unset 128. Flip the bit! Change-Id: I1dbde1915d8b269c11643a1636565a560eb07334 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/coreboot/+/39770 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- src/soc/intel/broadwell/igd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/soc/intel/broadwell') diff --git a/src/soc/intel/broadwell/igd.c b/src/soc/intel/broadwell/igd.c index 37f3871483..ecb5417181 100644 --- a/src/soc/intel/broadwell/igd.c +++ b/src/soc/intel/broadwell/igd.c @@ -348,10 +348,10 @@ static void igd_setup_panel(struct device *dev) south_chicken2 = gtt_read(SOUTH_CHICKEN2); if (conf->gpu_pch_backlight_pwm_hz > hz_limit) { pwm_increment = 16; - south_chicken2 &= ~(1 << 5); + south_chicken2 |= 1 << 5; } else { pwm_increment = 128; - south_chicken2 |= 1 << 5; + south_chicken2 &= ~(1 << 5); } gtt_write(SOUTH_CHICKEN2, south_chicken2); -- cgit v1.2.3