From 6b522c31aa55f1e09b63843e183c0f6f298a5605 Mon Sep 17 00:00:00 2001 From: Werner Zeh Date: Thu, 22 Nov 2018 15:10:18 +0100 Subject: intelblocks/cpu: Fix wrong comment for P_Req field in PERF_CTL MSR The mentioned bits 14:8 are wrong as the functions always write bits 15:8. What happens is visible in the written code. There is no need for an extra comment. Change-Id: I59b4d24d01a0a8fa74912f9754e7bbb217ca269d Signed-off-by: Werner Zeh Reviewed-on: https://review.coreboot.org/c/29798 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber Reviewed-by: Mario Scheithauer --- src/soc/intel/common/block/include/intelblocks/cpulib.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src/soc/intel/common/block/include/intelblocks') diff --git a/src/soc/intel/common/block/include/intelblocks/cpulib.h b/src/soc/intel/common/block/include/intelblocks/cpulib.h index 0d51146752..5cea96e409 100644 --- a/src/soc/intel/common/block/include/intelblocks/cpulib.h +++ b/src/soc/intel/common/block/include/intelblocks/cpulib.h @@ -20,7 +20,7 @@ #include /* - * Set PERF_CTL MSR (0x199) P_Req (14:8 bits) with + * Set PERF_CTL MSR (0x199) P_Req with * Turbo Ratio which is the Maximum Ratio. */ void cpu_set_max_ratio(void); @@ -52,7 +52,7 @@ int cpu_config_tdp_levels(void); * 23:16 - MAX_TURBO_3_CORES * 31:24 - MAX_TURBO_4_CORES * - * Set PERF_CTL MSR (0x199) P_Req (14:8 bits) with that value. + * Set PERF_CTL MSR (0x199) P_Req with that value. */ void cpu_set_p_state_to_turbo_ratio(void); @@ -61,7 +61,7 @@ void cpu_set_p_state_to_turbo_ratio(void); * TDP level ratio to be used for specific processor (in units * of 100MHz). * - * Set PERF_CTL MSR (0x199) P_Req (14:8 bits) with that value. + * Set PERF_CTL MSR (0x199) P_Req with that value. */ void cpu_set_p_state_to_nominal_tdp_ratio(void); @@ -69,12 +69,12 @@ void cpu_set_p_state_to_nominal_tdp_ratio(void); * PLATFORM_INFO MSR (0xCE) Bits 15:8 tells * MAX_NON_TURBO_LIM_RATIO. * - * Set PERF_CTL MSR (0x199) P_Req (14:8 bits) with that value. + * Set PERF_CTL MSR (0x199) P_Req with that value. */ void cpu_set_p_state_to_max_non_turbo_ratio(void); /* - * Set PERF_CTL MSR (0x199) P_Req (14:8 bits) with the value + * Set PERF_CTL MSR (0x199) P_Req with the value * for maximum efficiency. This value is reported in PLATFORM_INFO MSR (0xCE) * in Bits 47:40 and is extracted with cpu_get_min_ratio(). */ -- cgit v1.2.3