From 0dddcd76d74274715b0472ca41ddac88a5203b84 Mon Sep 17 00:00:00 2001 From: Barnali Sarkar Date: Tue, 2 Aug 2016 17:49:56 +0530 Subject: soc/intel/skylake: Cleanup patch for Skylake SoC Here is the list of items of code cleanup 1. Define TCO registers in smbus.h and not in pmc.h (as per EDS). 2. Include smbus.h wherever these TCO register defines were used. 3. Remove duplication of define in gpio_defs.h. 4. Remove unnecessary console.h include from memmap.h as no prints done. 5. Remove unnecessary comment from pch.c. BUG=none BRANCH=none TEST=Built and boot kunimitsu. Change-Id: Ibe6d2537ddde3c1c7f8ea5ada1bfaa9be79c0e3b Signed-off-by: Barnali Sarkar Reviewed-on: https://review.coreboot.org/16027 Tested-by: build bot (Jenkins) Reviewed-by: Rizwan Qureshi Reviewed-by: Paul Menzel Reviewed-by: Aaron Durbin Reviewed-by: Subrata Banik --- src/soc/intel/skylake/elog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/soc/intel/skylake/elog.c') diff --git a/src/soc/intel/skylake/elog.c b/src/soc/intel/skylake/elog.c index ca6455e496..8d5d4fec63 100644 --- a/src/soc/intel/skylake/elog.c +++ b/src/soc/intel/skylake/elog.c @@ -20,7 +20,7 @@ #include #include #include -#include +#include static void pch_log_gpio_gpe(u32 gpe0_sts, u32 gpe0_en, int start) { -- cgit v1.2.3