From 3ad24c7137650fe194e9edae55f5d3ce6de0a270 Mon Sep 17 00:00:00 2001 From: Raul E Rangel Date: Mon, 26 Apr 2021 09:55:42 -0600 Subject: soc/amd/common/smi_handler: Print warning when receiving an SCI SMI We don't have any infrastructure setup to handle SCI SMIs. Instead of just silently ignoring the SMI, print a warning saying that it is being ignored. BUG=none TEST=Trigger an SCI SMI and see warning printed. Signed-off-by: Raul E Rangel Change-Id: I803e572250925b7d5ffdbb3e8958f9aff1f808df Reviewed-on: https://review.coreboot.org/c/coreboot/+/52674 Reviewed-by: Felix Held Tested-by: build bot (Jenkins) --- src/soc/amd/common/block/cpu/smm/smi_handler.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/soc') diff --git a/src/soc/amd/common/block/cpu/smm/smi_handler.c b/src/soc/amd/common/block/cpu/smm/smi_handler.c index 00c03f022e..e535cb0f14 100644 --- a/src/soc/amd/common/block/cpu/smm/smi_handler.c +++ b/src/soc/amd/common/block/cpu/smm/smi_handler.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include +#include #include #include #include @@ -34,9 +35,12 @@ void southbridge_smi_handler(void) { const uint16_t smi_src = smi_read16(SMI_REG_POINTER); - if (smi_src & SMI_STATUS_SRC_SCI) + if (smi_src & SMI_STATUS_SRC_SCI) { + printk(BIOS_WARNING, "Ignoring SCI SMI: %#x\n", smi_read32(SMI_SCI_STATUS)); + /* Clear events to prevent re-entering SMI if event isn't handled */ clear_smi_sci_status(); + } if (smi_src & SMI_STATUS_SRC_0) process_smi_sources(SMI_REG_SMISTS0); if (smi_src & SMI_STATUS_SRC_1) -- cgit v1.2.3