From f44f331e169622f228d08a3051e9215747cce61f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Fri, 12 Jul 2019 08:02:35 +0300 Subject: intel/fsp_baytrail: Avoid preprocessor with HAVE_SMI_HANDLER MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The code should probably set SCI routing if built with HAVE_SMI_HANDLER=n. Change-Id: I0ada4b2a16490a15d8036a9425c4f768f7b8f218 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/34255 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- src/soc/intel/fsp_baytrail/gpio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src/soc') diff --git a/src/soc/intel/fsp_baytrail/gpio.c b/src/soc/intel/fsp_baytrail/gpio.c index 8d4e090a40..2409eaa541 100644 --- a/src/soc/intel/fsp_baytrail/gpio.c +++ b/src/soc/intel/fsp_baytrail/gpio.c @@ -192,6 +192,10 @@ static void setup_gpio_route(const struct soc_gpio_map *sus, uint32_t route_reg = 0; int i; + /* FIXME: SCI interrupts should be routed regardlessy. */ + if (!CONFIG(HAVE_SMI_HANDLER)) + return; + for (i = 0; i < 8; i++) { /* SMI takes precedence and wake_en implies SCI. */ if (sus[i].smi) { @@ -207,9 +211,7 @@ static void setup_gpio_route(const struct soc_gpio_map *sus, } } -#if CONFIG(HAVE_SMI_HANDLER) southcluster_smm_save_gpio_route(route_reg); -#endif } static void setup_dirqs(const u8 dirq[GPIO_MAX_DIRQS], -- cgit v1.2.3