From 61fcb7e9654634cfe0c8a7bf56581fb54d943bd8 Mon Sep 17 00:00:00 2001 From: Jakub Czapiga Date: Fri, 19 Feb 2021 11:44:22 +0100 Subject: acpi/acpigen.h: Add more intuitive AML package closing functions Until now every AML package had to be closed using acpigen_pop_len(). This commit introduces set of package closing functions corresponding with their opening function names. For example acpigen_write_if() opens if-statement package, acpigen_write_if_end() closes it. Now acpigen_write_else() closes previously opened acpigen_write_if(), so acpigen_pop_len() is not required before it. Signed-off-by: Jakub Czapiga Change-Id: Icfdc3804cd93bde049cd11dec98758b3a639eafd Reviewed-on: https://review.coreboot.org/c/coreboot/+/50910 Tested-by: build bot (Jenkins) Reviewed-by: Lance Zhao Reviewed-by: Angel Pons --- src/southbridge/intel/common/acpi_pirq_gen.c | 1 - 1 file changed, 1 deletion(-) (limited to 'src/southbridge/intel/common') diff --git a/src/southbridge/intel/common/acpi_pirq_gen.c b/src/southbridge/intel/common/acpi_pirq_gen.c index 6100be850c..73d101955b 100644 --- a/src/southbridge/intel/common/acpi_pirq_gen.c +++ b/src/southbridge/intel/common/acpi_pirq_gen.c @@ -94,7 +94,6 @@ void intel_acpi_gen_def_acpi_pirq(const struct device *dev) acpigen_write_package(num_devs); gen_pirq_route(EMIT_APIC, lpcb_path, pci_int_mapping); acpigen_pop_len(); /* package */ - acpigen_pop_len(); /* if PICM */ acpigen_write_else(); acpigen_emit_byte(RETURN_OP); acpigen_write_package(num_devs); -- cgit v1.2.3