From 5a98bf2c0a9c1616e7fc807e0b5d8a2cbcf9062e Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Tue, 8 Dec 2015 15:26:46 -0700 Subject: ACPI: Fix IASL Warning about unused method for _TZ checks According to the ACPI Spec for CondRefOf, the result argument is optional. In all of these locations, it was getting set but not used, creating a warning in new versions of IASL. Since it's an optional argument, just remove it. dsdt.aml 640: If (CondRefOf (^GBUF, Local0)) { Warning 3144 - Method Local is set but never used ^ (Local0) Change-Id: Iddf46a4faab19019882847917397eee0614302b9 Signed-off-by: Martin Roth Reviewed-on: https://review.coreboot.org/12695 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer --- src/southbridge/intel/bd82x6x/acpi/globalnvs.asl | 4 ++-- src/southbridge/intel/fsp_bd82x6x/acpi/globalnvs.asl | 4 ++-- src/southbridge/intel/fsp_i89xx/acpi/globalnvs.asl | 4 ++-- src/southbridge/intel/lynxpoint/acpi/globalnvs.asl | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) (limited to 'src/southbridge') diff --git a/src/southbridge/intel/bd82x6x/acpi/globalnvs.asl b/src/southbridge/intel/bd82x6x/acpi/globalnvs.asl index 68b4190529..ad027160a6 100644 --- a/src/southbridge/intel/bd82x6x/acpi/globalnvs.asl +++ b/src/southbridge/intel/bd82x6x/acpi/globalnvs.asl @@ -238,12 +238,12 @@ External (\_TZ.SKIN) Method (TZUP) { /* Update Primary Thermal Zone */ - If (CondRefOf (\_TZ.THRM, Local0)) { + If (CondRefOf (\_TZ.THRM)) { Notify (\_TZ.THRM, 0x81) } /* Update Secondary Thermal Zone */ - If (CondRefOf (\_TZ.SKIN, Local0)) { + If (CondRefOf (\_TZ.SKIN)) { Notify (\_TZ.SKIN, 0x81) } } diff --git a/src/southbridge/intel/fsp_bd82x6x/acpi/globalnvs.asl b/src/southbridge/intel/fsp_bd82x6x/acpi/globalnvs.asl index 0fb943c85a..3adf3caa84 100644 --- a/src/southbridge/intel/fsp_bd82x6x/acpi/globalnvs.asl +++ b/src/southbridge/intel/fsp_bd82x6x/acpi/globalnvs.asl @@ -224,12 +224,12 @@ External (\_TZ.SKIN) Method (TZUP) { /* Update Primary Thermal Zone */ - If (CondRefOf (\_TZ.THRM, Local0)) { + If (CondRefOf (\_TZ.THRM)) { Notify (\_TZ.THRM, 0x81) } /* Update Secondary Thermal Zone */ - If (CondRefOf (\_TZ.SKIN, Local0)) { + If (CondRefOf (\_TZ.SKIN)) { Notify (\_TZ.SKIN, 0x81) } } diff --git a/src/southbridge/intel/fsp_i89xx/acpi/globalnvs.asl b/src/southbridge/intel/fsp_i89xx/acpi/globalnvs.asl index f124eb0aee..e1e0e6648a 100644 --- a/src/southbridge/intel/fsp_i89xx/acpi/globalnvs.asl +++ b/src/southbridge/intel/fsp_i89xx/acpi/globalnvs.asl @@ -228,12 +228,12 @@ External (\_TZ.SKIN) Method (TZUP) { /* Update Primary Thermal Zone */ - If (CondRefOf (\_TZ.THRM, Local0)) { + If (CondRefOf (\_TZ.THRM)) { Notify (\_TZ.THRM, 0x81) } /* Update Secondary Thermal Zone */ - If (CondRefOf (\_TZ.SKIN, Local0)) { + If (CondRefOf (\_TZ.SKIN)) { Notify (\_TZ.SKIN, 0x81) } } diff --git a/src/southbridge/intel/lynxpoint/acpi/globalnvs.asl b/src/southbridge/intel/lynxpoint/acpi/globalnvs.asl index cbc3bd7e7f..468c755b16 100644 --- a/src/southbridge/intel/lynxpoint/acpi/globalnvs.asl +++ b/src/southbridge/intel/lynxpoint/acpi/globalnvs.asl @@ -222,12 +222,12 @@ External (\_TZ.SKIN) Method (TZUP) { /* Update Primary Thermal Zone */ - If (CondRefOf (\_TZ.THRM, Local0)) { + If (CondRefOf (\_TZ.THRM)) { Notify (\_TZ.THRM, 0x81) } /* Update Secondary Thermal Zone */ - If (CondRefOf (\_TZ.SKIN, Local0)) { + If (CondRefOf (\_TZ.SKIN)) { Notify (\_TZ.SKIN, 0x81) } } -- cgit v1.2.3