From 5c6bae213ea55e1436e010706560d86120b0b286 Mon Sep 17 00:00:00 2001 From: Uwe Hermann Date: Mon, 8 Nov 2010 15:16:30 +0000 Subject: Random ITE Super I/O fixes. - Drop some of the less useful / outdated / duplicated comments. - Simplify and streamline some code to look like the other Super I/Os. - Use u8/16/etc. everywhere. - ITE IT8718F: Add missing GPIO LDN. - Add missing braces around SIO_DATA #defines, potential bug even. Signed-off-by: Uwe Hermann Acked-by: Uwe Hermann git-svn-id: svn://svn.coreboot.org/coreboot/trunk@6047 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 --- src/superio/ite/it8671f/Makefile.inc | 2 +- src/superio/ite/it8671f/chip.h | 6 +++--- src/superio/ite/it8671f/it8671f.h | 5 ++--- src/superio/ite/it8671f/it8671f_early_serial.c | 20 +++++++++----------- src/superio/ite/it8671f/superio.c | 7 ++----- 5 files changed, 17 insertions(+), 23 deletions(-) (limited to 'src/superio/ite/it8671f') diff --git a/src/superio/ite/it8671f/Makefile.inc b/src/superio/ite/it8671f/Makefile.inc index 1870e62c15..b442ae0918 100644 --- a/src/superio/ite/it8671f/Makefile.inc +++ b/src/superio/ite/it8671f/Makefile.inc @@ -18,5 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## -#config chip.h ramstage-$(CONFIG_SUPERIO_ITE_IT8671F) += superio.c + diff --git a/src/superio/ite/it8671f/chip.h b/src/superio/ite/it8671f/chip.h index 7d0e5acb6a..529c6b4458 100644 --- a/src/superio/ite/it8671f/chip.h +++ b/src/superio/ite/it8671f/chip.h @@ -18,8 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#ifndef _SUPERIO_ITE_IT8671F -#define _SUPERIO_ITE_IT8671F +#ifndef SUPERIO_ITE_IT8671F_CHIP_H +#define SUPERIO_ITE_IT8671F_CHIP_H #include #include @@ -32,4 +32,4 @@ struct superio_ite_it8671f_config { struct pc_keyboard keyboard; }; -#endif /* _SUPERIO_ITE_IT8671F */ +#endif diff --git a/src/superio/ite/it8671f/it8671f.h b/src/superio/ite/it8671f/it8671f.h index 07b4d542cc..8c9daab6af 100644 --- a/src/superio/ite/it8671f/it8671f.h +++ b/src/superio/ite/it8671f/it8671f.h @@ -19,11 +19,10 @@ */ /* Datasheet: Not available online, got it from ITE per request. */ -/* Status: Com1 is tested and works. */ #define IT8671F_FDC 0x00 /* Floppy */ #define IT8671F_SP1 0x01 /* Com1 */ #define IT8671F_SP2 0x02 /* Com2 */ #define IT8671F_PP 0x03 /* Parallel port */ -#define IT8671F_KBCK 0x05 /* Keyboard */ -#define IT8671F_KBCM 0x06 /* Mouse */ +#define IT8671F_KBCK 0x05 /* PS/2 keyboard */ +#define IT8671F_KBCM 0x06 /* PS/2 mouse */ diff --git a/src/superio/ite/it8671f/it8671f_early_serial.c b/src/superio/ite/it8671f/it8671f_early_serial.c index 849235f1ce..68062ec813 100644 --- a/src/superio/ite/it8671f/it8671f_early_serial.c +++ b/src/superio/ite/it8671f/it8671f_early_serial.c @@ -38,18 +38,14 @@ * Special values used for entering MB PnP mode. The first four bytes of * each line determine the address port, the last four are data. */ -static const uint8_t init_values[] = { +static const u8 init_values[] = { 0x6a, 0xb5, 0xda, 0xed, /**/ 0xf6, 0xfb, 0x7d, 0xbe, 0xdf, 0x6f, 0x37, 0x1b, /**/ 0x0d, 0x86, 0xc3, 0x61, 0xb0, 0x58, 0x2c, 0x16, /**/ 0x8b, 0x45, 0xa2, 0xd1, 0xe8, 0x74, 0x3a, 0x9d, /**/ 0xce, 0xe7, 0x73, 0x39, }; -/* - * The content of IT8671F_CONFIG_REG_LDN (index 0x07) must be set to the - * LDN the register belongs to, before you can access the register. - */ -static void it8671f_sio_write(uint8_t ldn, uint8_t index, uint8_t value) +static void it8671f_sio_write(u8 ldn, u8 index, u8 value) { outb(IT8671F_CONFIG_REG_LDN, SIO_BASE); outb(ldn, SIO_DATA); @@ -60,7 +56,7 @@ static void it8671f_sio_write(uint8_t ldn, uint8_t index, uint8_t value) /* Enter the configuration state (MB PnP mode). */ static void it8671f_enter_conf(void) { - uint8_t i; + int i; /* Perform MB PnP setup to put the SIO chip at 0x3f0. */ /* Base address 0x3f0: 0x86 0x80 0x55 0x55. */ @@ -90,13 +86,15 @@ void it8671f_48mhz_clkin(void) it8671f_exit_conf(); } -/* Enable the serial ports on the IT8671F Super I/O chip. */ -static void it8671f_enable_serial(device_t dev, unsigned iobase) +/* Enable the serial port(s). */ +static void it8671f_enable_serial(device_t dev, u16 iobase) { it8671f_enter_conf(); - /* Allow all devices to be enabled. Bits: FDC (0), Com1 (1), Com2 (2), - PP (3), Reserved (4), KBCK (5), KBCM (6), Reserved (7). */ + /* + * Allow all devices to be enabled. Bits: FDC (0), Com1 (1), Com2 (2), + * PP (3), Reserved (4), KBCK (5), KBCM (6), Reserved (7). + */ it8671f_sio_write(0x00, IT8671F_CONFIG_REG_LDE, 0x6f); /* Enable serial port(s). */ diff --git a/src/superio/ite/it8671f/superio.c b/src/superio/ite/it8671f/superio.c index 9fd60425e1..9c5296df6c 100644 --- a/src/superio/ite/it8671f/superio.c +++ b/src/superio/ite/it8671f/superio.c @@ -28,14 +28,11 @@ static void init(device_t dev) { - struct superio_ite_it8671f_config *conf; + struct superio_ite_it8671f_config *conf = dev->chip_info; struct resource *res0, *res1; - if (!dev->enabled) { + if (!dev->enabled) return; - } - - conf = dev->chip_info; switch (dev->path.pnp.device) { case IT8671F_FDC: /* TODO. */ -- cgit v1.2.3