From 117849ef4d02fe3888fac1742511ca812cac811b Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Sun, 4 Jan 2015 16:34:03 +1100 Subject: superio/smsc/lpc47b272: Use link-time symbols over .c inclusion MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: Id3d5f2a120c0a933c031102f206829305da20f0c Signed-off-by: Edward O'Callaghan Reviewed-on: http://review.coreboot.org/8081 Tested-by: build bot (Jenkins) Reviewed-by: Kyösti Mälkki --- src/superio/smsc/lpc47b272/Makefile.inc | 1 + src/superio/smsc/lpc47b272/early_serial.c | 4 +++- src/superio/smsc/lpc47b272/lpc47b272.h | 11 ++++++++--- 3 files changed, 12 insertions(+), 4 deletions(-) (limited to 'src/superio/smsc/lpc47b272') diff --git a/src/superio/smsc/lpc47b272/Makefile.inc b/src/superio/smsc/lpc47b272/Makefile.inc index 680e937f77..8102229db5 100644 --- a/src/superio/smsc/lpc47b272/Makefile.inc +++ b/src/superio/smsc/lpc47b272/Makefile.inc @@ -18,4 +18,5 @@ ## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA ## +romstage-$(CONFIG_SUPERIO_SMSC_LPC47B272) += early_serial.c ramstage-$(CONFIG_SUPERIO_SMSC_LPC47B272) += superio.c diff --git a/src/superio/smsc/lpc47b272/early_serial.c b/src/superio/smsc/lpc47b272/early_serial.c index 3624df272f..88afca556f 100644 --- a/src/superio/smsc/lpc47b272/early_serial.c +++ b/src/superio/smsc/lpc47b272/early_serial.c @@ -21,6 +21,8 @@ /* Pre-RAM driver for SMSC LPC47B272 Super I/O chip. */ #include +#include +#include #include "lpc47b272.h" static void pnp_enter_conf_state(pnp_devfn_t dev) @@ -42,7 +44,7 @@ static void pnp_exit_conf_state(pnp_devfn_t dev) * @param dev High 8 bits = Super I/O port, low 8 bits = logical device number. * @param iobase Processor I/O port address to assign to this serial device. */ -static void lpc47b272_enable_serial(pnp_devfn_t dev, u16 iobase) +void lpc47b272_enable_serial(pnp_devfn_t dev, u16 iobase) { pnp_enter_conf_state(dev); pnp_set_logical_device(dev); diff --git a/src/superio/smsc/lpc47b272/lpc47b272.h b/src/superio/smsc/lpc47b272/lpc47b272.h index cbfdb1307b..a311708518 100644 --- a/src/superio/smsc/lpc47b272/lpc47b272.h +++ b/src/superio/smsc/lpc47b272/lpc47b272.h @@ -18,8 +18,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ -#ifndef SUPERIO_SMSC_LPC47B272_LPC47B272_H -#define SUPERIO_SMSC_LPC47B272_LPC47B272_H +#ifndef SUPERIO_SMSC_LPC47B272_H +#define SUPERIO_SMSC_LPC47B272_H #define LPC47B272_FDC 0 /* Floppy */ #define LPC47B272_PP 3 /* Parallel Port */ @@ -30,4 +30,9 @@ #define LPC47B272_MAX_CONFIG_REGISTER 0x5F -#endif +#include +#include + +void lpc47b272_enable_serial(pnp_devfn_t dev, u16 iobase); + +#endif /* SUPERIO_SMSC_LPC47B272_H */ -- cgit v1.2.3