From f21bdc3020b24cce585c4df69b06913177c94182 Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Tue, 21 Oct 2014 07:43:41 +1100 Subject: superio/*/superio.c: Don't hide pointer types behind typedefs Hiding pointer types behind 'typedef's is usually not a great idea at the best of times. Worse the typedef becomes an integer at different stages in Coreboot. Let us refrain from doing this at all. Change-Id: Ia2ca8c98bb489daaa58f379433875864f6efabc8 Signed-off-by: Edward O'Callaghan Reviewed-on: http://review.coreboot.org/7136 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber --- src/superio/winbond/w83627dhg/superio.c | 4 ++-- src/superio/winbond/w83627ehg/superio.c | 8 ++++---- src/superio/winbond/w83627hf/superio.c | 8 ++++---- src/superio/winbond/w83627thg/superio.c | 4 ++-- src/superio/winbond/w83627uhg/superio.c | 6 +++--- src/superio/winbond/w83697hf/superio.c | 2 +- src/superio/winbond/w83977f/superio.c | 4 ++-- src/superio/winbond/w83977tf/superio.c | 4 ++-- 8 files changed, 20 insertions(+), 20 deletions(-) (limited to 'src/superio/winbond') diff --git a/src/superio/winbond/w83627dhg/superio.c b/src/superio/winbond/w83627dhg/superio.c index fdab974b93..ee01cfda87 100644 --- a/src/superio/winbond/w83627dhg/superio.c +++ b/src/superio/winbond/w83627dhg/superio.c @@ -25,7 +25,7 @@ #include #include "w83627dhg.h" -static void w83627dhg_enable_UR2(device_t dev) +static void w83627dhg_enable_UR2(struct device *dev) { u8 reg8; @@ -36,7 +36,7 @@ static void w83627dhg_enable_UR2(device_t dev) pnp_exit_conf_mode(dev); } -static void w83627dhg_init(device_t dev) +static void w83627dhg_init(struct device *dev) { if (!dev->enabled) diff --git a/src/superio/winbond/w83627ehg/superio.c b/src/superio/winbond/w83627ehg/superio.c index aae0ac453e..73ab022859 100644 --- a/src/superio/winbond/w83627ehg/superio.c +++ b/src/superio/winbond/w83627ehg/superio.c @@ -44,7 +44,7 @@ static u8 pnp_read_index(u16 port, u8 reg) return inb(port + 1); } -static void enable_hwm_smbus(device_t dev) +static void enable_hwm_smbus(struct device *dev) { u8 reg8; @@ -54,7 +54,7 @@ static void enable_hwm_smbus(device_t dev) pnp_write_config(dev, 0x2a, reg8); } -static void init_acpi(device_t dev) +static void init_acpi(struct device *dev) { u8 value = 0x20; /* TODO: 0x20 value here never used? */ int power_on = 1; @@ -92,7 +92,7 @@ static void init_hwm(u16 base) } } -static void w83627ehg_init(device_t dev) +static void w83627ehg_init(struct device *dev) { struct resource *res0; @@ -114,7 +114,7 @@ static void w83627ehg_init(device_t dev) } } -static void w83627ehg_pnp_enable_resources(device_t dev) +static void w83627ehg_pnp_enable_resources(struct device *dev) { pnp_enable_resources(dev); diff --git a/src/superio/winbond/w83627hf/superio.c b/src/superio/winbond/w83627hf/superio.c index 5445b47a58..2d69fad201 100644 --- a/src/superio/winbond/w83627hf/superio.c +++ b/src/superio/winbond/w83627hf/superio.c @@ -44,7 +44,7 @@ static u8 pnp_read_index(u16 port, u8 reg) return inb(port + 1); } -static void enable_hwm_smbus(device_t dev) +static void enable_hwm_smbus(struct device *dev) { u8 reg8; @@ -54,7 +54,7 @@ static void enable_hwm_smbus(device_t dev) pnp_write_config(dev, 0x2b, reg8); } -static void init_acpi(device_t dev) +static void init_acpi(struct device *dev) { u8 value = 0x20; /* FIXME: The 0x20 value here is never used? */ int power_on = 1; @@ -99,7 +99,7 @@ static void init_hwm(u16 base) } } -static void w83627hf_init(device_t dev) +static void w83627hf_init(struct device *dev) { struct resource *res0; @@ -121,7 +121,7 @@ static void w83627hf_init(device_t dev) } } -static void w83627hf_pnp_enable_resources(device_t dev) +static void w83627hf_pnp_enable_resources(struct device *dev) { pnp_enable_resources(dev); diff --git a/src/superio/winbond/w83627thg/superio.c b/src/superio/winbond/w83627thg/superio.c index 75186fae6c..d7319330b8 100644 --- a/src/superio/winbond/w83627thg/superio.c +++ b/src/superio/winbond/w83627thg/superio.c @@ -29,7 +29,7 @@ #include #include "w83627thg.h" -static void w83627thg_init(device_t dev) +static void w83627thg_init(struct device *dev) { if (!dev->enabled) @@ -64,7 +64,7 @@ static struct pnp_info pnp_dev_info[] = { { &ops, W83627THG_HWM, PNP_IO0 | PNP_IRQ0, {0x0ff8, 0}, }, }; -static void enable_dev(device_t dev) +static void enable_dev(struct device *dev) { pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info), pnp_dev_info); } diff --git a/src/superio/winbond/w83627uhg/superio.c b/src/superio/winbond/w83627uhg/superio.c index f0d9aefae4..7e3ebdbd05 100644 --- a/src/superio/winbond/w83627uhg/superio.c +++ b/src/superio/winbond/w83627uhg/superio.c @@ -44,7 +44,7 @@ * Warning: The kernel will need to be adjusted since it assumes * a 1.8462 MHz clock. */ -static void set_uart_clock_source(device_t dev, u8 uart_clock) +static void set_uart_clock_source(struct device *dev, u8 uart_clock) { u8 value; @@ -57,7 +57,7 @@ static void set_uart_clock_source(device_t dev, u8 uart_clock) pnp_exit_conf_mode(dev); } -static void w83627uhg_init(device_t dev) +static void w83627uhg_init(struct device *dev) { if (!dev->enabled) @@ -115,7 +115,7 @@ static struct pnp_info pnp_dev_info[] = { { &ops, W83627UHG_SP6, PNP_IO0 | PNP_IRQ0, {0x07f8, 0}, }, }; -static void enable_dev(device_t dev) +static void enable_dev(struct device *dev) { pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info), pnp_dev_info); } diff --git a/src/superio/winbond/w83697hf/superio.c b/src/superio/winbond/w83697hf/superio.c index 9d9742c75d..195f941947 100644 --- a/src/superio/winbond/w83697hf/superio.c +++ b/src/superio/winbond/w83697hf/superio.c @@ -50,7 +50,7 @@ static void hwmon_set_fan_divisor(unsigned int base, int num, unsigned int divis } } -static void w83697hf_init(device_t dev) +static void w83697hf_init(struct device *dev) { struct resource *res0; struct superio_winbond_w83697hf_config *cfg; diff --git a/src/superio/winbond/w83977f/superio.c b/src/superio/winbond/w83977f/superio.c index 232f46adc4..5cc9732b5a 100644 --- a/src/superio/winbond/w83977f/superio.c +++ b/src/superio/winbond/w83977f/superio.c @@ -28,7 +28,7 @@ #include #include "w83977f.h" -static void w83977f_init(device_t dev) +static void w83977f_init(struct device *dev) { if (!dev->enabled) @@ -62,7 +62,7 @@ static struct pnp_info pnp_dev_info[] = { { &ops, W83977F_GPIO2, PNP_IO0, {0x07f8, 0}, }, }; -static void enable_dev(device_t dev) +static void enable_dev(struct device *dev) { pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info), pnp_dev_info); } diff --git a/src/superio/winbond/w83977tf/superio.c b/src/superio/winbond/w83977tf/superio.c index a61770aa9f..62be15a017 100644 --- a/src/superio/winbond/w83977tf/superio.c +++ b/src/superio/winbond/w83977tf/superio.c @@ -30,7 +30,7 @@ #include #include "w83977tf.h" -static void w83977tf_init(device_t dev) +static void w83977tf_init(struct device *dev) { if (!dev->enabled) @@ -63,7 +63,7 @@ static struct pnp_info pnp_dev_info[] = { { &ops, W83977TF_ACPI, PNP_IRQ0, }, }; -static void enable_dev(device_t dev) +static void enable_dev(struct device *dev) { pnp_enable_devices(dev, &ops, ARRAY_SIZE(pnp_dev_info), pnp_dev_info); } -- cgit v1.2.3