From 4d2d5d5b3e661683ab209d068ab7537332fe15f9 Mon Sep 17 00:00:00 2001 From: efdesign98 Date: Wed, 14 Sep 2011 19:34:13 -0600 Subject: AMD Agesa macro expansion fix This change fixes the use of a macro that was previously modified to fix a warning. The macro was used in a manner that doubly incremented a pointer. The pointer increment was removed from the macro call and moved elsewhere. In addition, an unused macro was removed from both Family 12 and Family 14 code. Change-Id: I577794bbc55d18f21170dda1d0bbdc6d776ce392 Signed-off-by: Frank Vibrans Signed-off-by: efdesign98 Reviewed-on: http://review.coreboot.org/217 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- src/vendorcode/amd/agesa/f12/Proc/GNB/Common/GnbPcie.h | 3 --- 1 file changed, 3 deletions(-) (limited to 'src/vendorcode/amd/agesa/f12') diff --git a/src/vendorcode/amd/agesa/f12/Proc/GNB/Common/GnbPcie.h b/src/vendorcode/amd/agesa/f12/Proc/GNB/Common/GnbPcie.h index b29afa6892..c8a4c9b910 100755 --- a/src/vendorcode/amd/agesa/f12/Proc/GNB/Common/GnbPcie.h +++ b/src/vendorcode/amd/agesa/f12/Proc/GNB/Common/GnbPcie.h @@ -74,9 +74,6 @@ //#define PCIE_LINK_GPIO_RESET_ASSERT_TIME (2 * 1000) //#define PCIE_LINK_RESET_TO_TRAINING_TIME (2 * 1000) -#define IS_LAST_DESCRIPTOR(Descriptor) (Descriptor != NULL ? ((Descriptor->Header.DescriptorFlags & DESCRIPTOR_TERMINATE_LIST) == 0) : (1==1)) -#define IS_VALID_DESCRIPTOR(Descriptor) (Descriptor != NULL ? ((Descriptor->Header.DescriptorFlags & DESCRIPTOR_ALLOCATED) != 0) : (1==0)) - // Get lowest PHY lane on engine #define PcieLibGetLoPhyLane(Engine) (Engine != NULL ? ((Engine->EngineData.StartLane > Engine->EngineData.EndLane) ? Engine->EngineData.EndLane : Engine->EngineData.StartLane) : 0xFF) // Get highest PHY lane on engine -- cgit v1.2.3