From 270e300e12c43aa1fb0124d58de2883d53f85f3b Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Sun, 14 Dec 2014 15:43:45 -0700 Subject: fsp_baytrail: Initialize LPC pads in bootblock for port 80 Port 80h codes were coming out of bootblock and romstage scrambled, or were not coming out at all. Initializing the LPC signal pads as LPC fixes that issue. Change-Id: I16943513f2eb6fe8fa58766aaa82dac182440c34 Signed-off-by: Martin Roth Reviewed-on: http://review.coreboot.org/7802 Tested-by: build bot (Jenkins) Reviewed-by: Werner Zeh Reviewed-by: Stefan Reinauer --- src/soc/intel/fsp_baytrail/baytrail/gpio.h | 8 ++++++++ src/soc/intel/fsp_baytrail/bootblock/bootblock.c | 15 +++++++++++++++ 2 files changed, 23 insertions(+) (limited to 'src') diff --git a/src/soc/intel/fsp_baytrail/baytrail/gpio.h b/src/soc/intel/fsp_baytrail/baytrail/gpio.h index 600f4e97f4..e13b663273 100644 --- a/src/soc/intel/fsp_baytrail/baytrail/gpio.h +++ b/src/soc/intel/fsp_baytrail/baytrail/gpio.h @@ -286,6 +286,8 @@ #define GPSSUS_GPIO_F1_RANGE_START 11 #define GPSSUS_GPIO_F1_RANGE_END 21 +#ifndef __BOOT_BLOCK__ + struct soc_gpio_map { u32 pad_conf0; u32 pad_conf1; @@ -328,6 +330,8 @@ uint8_t read_ssus_gpio(uint8_t gpio_num); void configure_ssus_gpio(uint8_t gpio_num, uint32_t pconf0, uint32_t pad_val); void configure_score_gpio(uint8_t gpio_num, uint32_t pconf0, uint32_t pad_val); +#endif /* #ifndef __BOOT_BLOCK__ */ + /* Functions / defines for changing GPIOs in romstage */ /* SCORE Pad definitions. */ #define UART_RXD_PAD 82 @@ -367,6 +371,8 @@ static inline void ssus_select_func(int pad, int func) write32(pconf0_addr, reg); } +#ifndef __BOOT_BLOCK__ + /* These functions require that the input pad be configured as an input GPIO */ static inline int score_get_gpio(int pad) { @@ -388,4 +394,6 @@ static inline void ssus_disable_internal_pull(int pad) write32(ssus_pconf0(pad), read32(ssus_pconf0(pad)) & pull_mask); } +#endif /* #ifndef __BOOT_BLOCK__ */ + #endif /* _BAYTRAIL_GPIO_H_ */ diff --git a/src/soc/intel/fsp_baytrail/bootblock/bootblock.c b/src/soc/intel/fsp_baytrail/bootblock/bootblock.c index 1623f04da1..e8f5572ef7 100644 --- a/src/soc/intel/fsp_baytrail/bootblock/bootblock.c +++ b/src/soc/intel/fsp_baytrail/bootblock/bootblock.c @@ -27,6 +27,7 @@ #include #include #include +#include #include /* @@ -100,6 +101,19 @@ static void setup_mmconfig(void) pci_io_write_config32(IOSF_PCI_DEV, MCR_REG, reg); } +static const uint8_t lpc_pads[12] = { + 70, 68, 67, 66, 69, 71, 65, 72, 86, 90, 88, 92, +}; + +static void set_up_lpc_pads(void) +{ + uint32_t reg = IO_BASE_ADDRESS | SET_BAR_ENABLE; + pci_write_config32(LPC_BDF, IOBASE, reg); + + for (reg = 0; reg < 12; reg++) + score_select_func(lpc_pads[reg], 1); +} + static void bootblock_cpu_init(void) { @@ -109,4 +123,5 @@ static void bootblock_cpu_init(void) setup_mmconfig(); enable_rom_caching(); enable_spi_prefetch(); + set_up_lpc_pads(); } -- cgit v1.2.3