From 46255f7ee4728e0ee02c0cb8d9edeeee1a8e5361 Mon Sep 17 00:00:00 2001 From: Simon Glass Date: Thu, 12 Jul 2018 15:26:07 -0600 Subject: Kconfig: Make the EM100 config option common This applied to AMD devices as well as Intel, although the mechanism is different. Move the option to a common place. BUG=b:111363976 TEST=USE=em100-mode emerge-reef coreboot See that a message appears: * Enabling em100 mode (slow SPI flash) Change-Id: Iea437bdf42e7bc49b1d28c812bfc6128e3eb68bd Signed-off-by: Simon Glass Reviewed-on: https://review.coreboot.org/27467 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- src/Kconfig | 18 ++++++++++++++++++ src/mainboard/google/kahlee/Kconfig | 1 + src/southbridge/intel/common/firmware/Kconfig | 7 +------ 3 files changed, 20 insertions(+), 6 deletions(-) (limited to 'src') diff --git a/src/Kconfig b/src/Kconfig index 24b21060b6..bce3e32884 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -1024,6 +1024,24 @@ config DEBUG_ADA_CODE Add the compiler switch `-gnata` to compile code guarded by `pragma Debug`. +config HAVE_EM100_SUPPORT + bool "Platform can support the Dediprog EM100 SPI emulator" + help + This is enabled by platforms which can support using the EM100. + +config EM100 + bool "Configure image for EM100 usage" + depends on HAVE_EM100_SUPPORT + help + The Dediprog EM100 SPI emulator allows fast loading of new SPI images + over USB. However it only supports a maximum SPI clock of 20MHz and + single data output. Enable this option to use a 20MHz SPI clock and + disable "Dual Output Fast Read" Support. + + On AMD platforms this changes the SPI speed at run-time if the + mainboard code supports this. On supported Intel platforms this works + by changing the settings in the descriptor.bin file. + endmenu diff --git a/src/mainboard/google/kahlee/Kconfig b/src/mainboard/google/kahlee/Kconfig index ef7db041d4..2e44a72865 100644 --- a/src/mainboard/google/kahlee/Kconfig +++ b/src/mainboard/google/kahlee/Kconfig @@ -39,6 +39,7 @@ config BOARD_GOOGLE_BASEBOARD_KAHLEE select DRIVERS_GENERIC_ADAU7002 select DRIVERS_GENERIC_MAX98357A select DRIVERS_I2C_DA7219 + select HAVE_EM100_SUPPORT if BOARD_GOOGLE_BASEBOARD_KAHLEE diff --git a/src/southbridge/intel/common/firmware/Kconfig b/src/southbridge/intel/common/firmware/Kconfig index 30c9aaf262..c9cf6f8760 100644 --- a/src/southbridge/intel/common/firmware/Kconfig +++ b/src/southbridge/intel/common/firmware/Kconfig @@ -26,6 +26,7 @@ comment "Intel Firmware" config HAVE_IFD_BIN bool "Add Intel descriptor.bin file" + select HAVE_EM100_SUPPORT # We use ifdtool to enable this. help The descriptor binary @@ -34,12 +35,6 @@ config IFD_BIN_PATH default "3rdparty/blobs/mainboard/$(MAINBOARDDIR)/descriptor.bin" depends on HAVE_IFD_BIN && !BUILD_WITH_FAKE_IFD -config EM100 - bool "Configure IFD for EM100 usage" - depends on HAVE_IFD_BIN && !BUILD_WITH_FAKE_IFD - help - Set SPI frequency to 20MHz and disable Dual Output Fast Read Support - config HAVE_ME_BIN bool "Add Intel ME/TXE firmware" depends on HAVE_IFD_BIN -- cgit v1.2.3