From 4d99cdeaf90561413e37d6b7efc3ce75321f31fc Mon Sep 17 00:00:00 2001 From: Elyes HAOUAS Date: Thu, 24 Oct 2019 11:55:37 +0200 Subject: src/mainboard: Drop wrong _ADR objects ACPI Version 6.3 Section 6.1: "A device object must contain either an _HID object or an _ADR object, but should not contain both." Change-Id: I50cafce0aaf465ee95562ccff6c8f63fb22096c0 Signed-off-by: Elyes HAOUAS Reviewed-on: https://review.coreboot.org/c/coreboot/+/36294 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl | 3 --- src/mainboard/aopen/dxplplusu/dsdt.asl | 1 - src/mainboard/asus/p2b-ls/dsdt.asl | 1 - src/mainboard/asus/p2b/dsdt.asl | 1 - src/mainboard/emulation/qemu-i440fx/dsdt.asl | 1 - src/mainboard/emulation/qemu-q35/dsdt.asl | 1 - src/mainboard/google/cyan/acpi/codec_maxim.asl | 2 -- src/mainboard/google/cyan/acpi/codec_realtek.asl | 1 - src/mainboard/google/link/acpi/mainboard.asl | 1 - src/mainboard/lenovo/t410/dsdt.asl | 1 - src/mainboard/lenovo/x201/dsdt.asl | 1 - src/mainboard/msi/ms9652_fam10/dsdt.asl | 1 - src/mainboard/packardbell/ms2290/dsdt.asl | 1 - 13 files changed, 16 deletions(-) (limited to 'src') diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl b/src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl index e04bf1d25b..0c4cd3881c 100644 --- a/src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl +++ b/src/mainboard/amd/serengeti_cheetah_fam10/dsdt.asl @@ -46,7 +46,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 1, OEM_ID, ACPI_TABLE_CREATOR, 100925440) External (CBB2) Name (_HID, EisaId ("PNP0A03")) - Name (_ADR, 0x00000000) Name (_UID, 0x01) Name (HCIN, 0x00) // HC1 @@ -118,7 +117,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 1, OEM_ID, ACPI_TABLE_CREATOR, 100925440) Device (PCI1) { Name (_HID, "PNP0A03") - Name (_ADR, 0x00000000) Name (_UID, 0x02) Method (_STA, 0, NotSerialized) { @@ -133,7 +131,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 1, OEM_ID, ACPI_TABLE_CREATOR, 100925440) Device (PCI2) { Name (_HID, "PNP0A03") - Name (_ADR, 0x00000000) Name (_UID, 0x02) Method (_STA, 0, NotSerialized) { diff --git a/src/mainboard/aopen/dxplplusu/dsdt.asl b/src/mainboard/aopen/dxplplusu/dsdt.asl index af8012efe8..4fde2442e9 100644 --- a/src/mainboard/aopen/dxplplusu/dsdt.asl +++ b/src/mainboard/aopen/dxplplusu/dsdt.asl @@ -28,7 +28,6 @@ Scope(\_SB) { Device(PCI0) { Name (_HID, EISAID("PNP0A03")) - Name (_ADR, 0x00) Name (_PRT, Package() { Package() { 0x001dffff, 0, 0, 16 }, Package() { 0x001dffff, 1, 0, 19 }, diff --git a/src/mainboard/asus/p2b-ls/dsdt.asl b/src/mainboard/asus/p2b-ls/dsdt.asl index 89cc66d834..83e1df6bc4 100644 --- a/src/mainboard/asus/p2b-ls/dsdt.asl +++ b/src/mainboard/asus/p2b-ls/dsdt.asl @@ -128,7 +128,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, OEM_ID, ACPI_TABLE_CREATOR, 1) Device (PCI0) { Name (_HID, EisaId ("PNP0A03")) - Name (_ADR, 0x00) Name (_UID, 0x00) Name (_BBN, 0x00) diff --git a/src/mainboard/asus/p2b/dsdt.asl b/src/mainboard/asus/p2b/dsdt.asl index 4a58c0781a..279f772e96 100644 --- a/src/mainboard/asus/p2b/dsdt.asl +++ b/src/mainboard/asus/p2b/dsdt.asl @@ -124,7 +124,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, OEM_ID, ACPI_TABLE_CREATOR, 1) Device (PCI0) { Name (_HID, EisaId ("PNP0A03")) - Name (_ADR, 0x00) Name (_UID, 0x00) Name (_BBN, 0x00) diff --git a/src/mainboard/emulation/qemu-i440fx/dsdt.asl b/src/mainboard/emulation/qemu-i440fx/dsdt.asl index e4be1139f3..9bef7d9c18 100644 --- a/src/mainboard/emulation/qemu-i440fx/dsdt.asl +++ b/src/mainboard/emulation/qemu-i440fx/dsdt.asl @@ -34,7 +34,6 @@ DefinitionBlock ( Scope(\_SB) { Device(PCI0) { Name(_HID, EisaId("PNP0A03")) - Name(_ADR, 0x00) Name(_UID, 1) } } diff --git a/src/mainboard/emulation/qemu-q35/dsdt.asl b/src/mainboard/emulation/qemu-q35/dsdt.asl index a861aed55c..ea17df21e2 100644 --- a/src/mainboard/emulation/qemu-q35/dsdt.asl +++ b/src/mainboard/emulation/qemu-q35/dsdt.asl @@ -49,7 +49,6 @@ DefinitionBlock ( Device(PCI0) { Name(_HID, EisaId("PNP0A08")) Name(_CID, EisaId("PNP0A03")) - Name(_ADR, 0x00) Name(_UID, 1) // _OSC: based on sample of ACPI3.0b spec diff --git a/src/mainboard/google/cyan/acpi/codec_maxim.asl b/src/mainboard/google/cyan/acpi/codec_maxim.asl index b412551a4a..b3eb25aeb0 100644 --- a/src/mainboard/google/cyan/acpi/codec_maxim.asl +++ b/src/mainboard/google/cyan/acpi/codec_maxim.asl @@ -20,7 +20,6 @@ Scope (\_SB.PCI0.I2C2) /* Maxim Audio Codec */ Device (MAXM) /* Audio Codec driver I2C */ { - Name (_ADR, 0) Name (_HID, AUDIO_CODEC_HID) Name (_CID, AUDIO_CODEC_CID) Name (_DDN, AUDIO_CODEC_DDN) @@ -64,7 +63,6 @@ Scope (\_SB.PCI0.I2C2) } Device (TISW) /* TI Switch driver I2C */ { - Name (_ADR, 0) Name (_HID, TI_SWITCH_HID) Name (_CID, TI_SWITCH_CID) Name (_DDN, TI_SWITCH_DDN) diff --git a/src/mainboard/google/cyan/acpi/codec_realtek.asl b/src/mainboard/google/cyan/acpi/codec_realtek.asl index d697aace3e..0d188701e7 100644 --- a/src/mainboard/google/cyan/acpi/codec_realtek.asl +++ b/src/mainboard/google/cyan/acpi/codec_realtek.asl @@ -20,7 +20,6 @@ Scope (\_SB.PCI0.I2C5) /* Realtek Audio Codec */ Device (RTEK) /* Audio Codec driver I2C */ { - Name (_ADR, 0) Name (_HID, AUDIO_CODEC_HID) Name (_CID, AUDIO_CODEC_CID) Name (_DDN, AUDIO_CODEC_DDN) diff --git a/src/mainboard/google/link/acpi/mainboard.asl b/src/mainboard/google/link/acpi/mainboard.asl index c153950047..79c45c8622 100644 --- a/src/mainboard/google/link/acpi/mainboard.asl +++ b/src/mainboard/google/link/acpi/mainboard.asl @@ -43,7 +43,6 @@ Scope (\_SB) { Device (TSCR) { - Name (_ADR, 0x0) Name (_UID, 2) // Report as a Sleep Button device so Linux will diff --git a/src/mainboard/lenovo/t410/dsdt.asl b/src/mainboard/lenovo/t410/dsdt.asl index 08e21225ca..afc9b3e4df 100644 --- a/src/mainboard/lenovo/t410/dsdt.asl +++ b/src/mainboard/lenovo/t410/dsdt.asl @@ -54,7 +54,6 @@ DefinitionBlock( Device (UNCR) { Name (_BBN, 0xFF) - Name (_ADR, 0x00) Name (RID, 0x00) Name (_HID, EisaId ("PNP0A03")) Name (_CRS, ResourceTemplate () diff --git a/src/mainboard/lenovo/x201/dsdt.asl b/src/mainboard/lenovo/x201/dsdt.asl index 08e21225ca..afc9b3e4df 100644 --- a/src/mainboard/lenovo/x201/dsdt.asl +++ b/src/mainboard/lenovo/x201/dsdt.asl @@ -54,7 +54,6 @@ DefinitionBlock( Device (UNCR) { Name (_BBN, 0xFF) - Name (_ADR, 0x00) Name (RID, 0x00) Name (_HID, EisaId ("PNP0A03")) Name (_CRS, ResourceTemplate () diff --git a/src/mainboard/msi/ms9652_fam10/dsdt.asl b/src/mainboard/msi/ms9652_fam10/dsdt.asl index f555c4d1ff..2115f4cc44 100644 --- a/src/mainboard/msi/ms9652_fam10/dsdt.asl +++ b/src/mainboard/msi/ms9652_fam10/dsdt.asl @@ -36,7 +36,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 1, OEM_ID, ACPI_TABLE_CREATOR, 1) Device (PCI0) { Name (_HID, EisaId ("PNP0A03")) - Name (_ADR, 0x00) Name (_UID, 0x00) Name (_BBN, 0x00) diff --git a/src/mainboard/packardbell/ms2290/dsdt.asl b/src/mainboard/packardbell/ms2290/dsdt.asl index ad3f9bd938..3bf7fbd430 100644 --- a/src/mainboard/packardbell/ms2290/dsdt.asl +++ b/src/mainboard/packardbell/ms2290/dsdt.asl @@ -48,7 +48,6 @@ DefinitionBlock( Device (UNCR) { Name (_BBN, 0xFF) - Name (_ADR, 0x00) Name (RID, 0x00) Name (_HID, EisaId ("PNP0A03")) Name (_CRS, ResourceTemplate () -- cgit v1.2.3