From 9733e283815b03d2ae602257ac080b195877df37 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Sun, 16 Aug 2015 17:06:30 +0200 Subject: nb/intel/sandybridge/raminit: Add edge write discovery check Make sure edge write test results are sane. Check rn.all to make sure rn.start and rn.end are valid. Most likely the following test is going to fail on the same rank anyway. Change-Id: Ifa601406e6c74ceb8d70063be5ce1bf6bc512c18 Signed-off-by: Patrick Rudolph Signed-off-by: Alexandru Gagniuc Reviewed-on: http://review.coreboot.org/11247 Tested-by: build bot (Jenkins) Reviewed-by: Vladimir Serbinenko --- src/northbridge/intel/sandybridge/raminit.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src') diff --git a/src/northbridge/intel/sandybridge/raminit.c b/src/northbridge/intel/sandybridge/raminit.c index 9df102afc6..76f62a6a8d 100644 --- a/src/northbridge/intel/sandybridge/raminit.c +++ b/src/northbridge/intel/sandybridge/raminit.c @@ -3130,6 +3130,8 @@ static void discover_edges_write_real(ramctr_timing * ctrl, int channel, upper[lane] = min(rn.end - ctrl->edge_offset[i], upper[lane]); edges[lane] = (lower[lane] + upper[lane]) / 2; + if (rn.all || (lower[lane] > upper[lane])) + die("edge write discovery failed"); } } -- cgit v1.2.3