From f2f53c447aaac242f45eaaa2e9af7e3c76047baa Mon Sep 17 00:00:00 2001 From: Tim Chu Date: Mon, 7 Sep 2020 02:30:19 -0700 Subject: arch/x86/smbios: Update SMBIOS type 0 ec version Update embedded controller firmware version for SMBIOS type 0. TEST=Execute "dmidecode -t 0" to check if the ec version is correct Signed-off-by: Tim Chu Change-Id: Ibd5ee27a1b8fa4e5bc66e359d3b62e052e19e8a2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45138 Tested-by: build bot (Jenkins) Reviewed-by: Jonathan Zhang Reviewed-by: Patrick Rudolph Reviewed-by: Angel Pons --- src/arch/x86/smbios.c | 2 ++ src/arch/x86/smbios_defaults.c | 6 ++++++ src/include/smbios.h | 2 ++ 3 files changed, 10 insertions(+) (limited to 'src') diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index 2cf4ac54ee..2995eceb9d 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -430,6 +430,8 @@ static int smbios_write_type0(unsigned long *current, int handle) t->system_bios_major_release = coreboot_major_revision; t->system_bios_minor_release = coreboot_minor_revision; + smbios_ec_revision(&t->ec_major_release, &t->ec_minor_release); + t->bios_characteristics = BIOS_CHARACTERISTICS_PCI_SUPPORTED | BIOS_CHARACTERISTICS_SELECTABLE_BOOT | diff --git a/src/arch/x86/smbios_defaults.c b/src/arch/x86/smbios_defaults.c index 22ce7a57cd..4d8883f3cd 100644 --- a/src/arch/x86/smbios_defaults.c +++ b/src/arch/x86/smbios_defaults.c @@ -63,6 +63,12 @@ __weak smbios_board_type smbios_mainboard_board_type(void) return SMBIOS_BOARD_TYPE_UNKNOWN; } +__weak void smbios_ec_revision(uint8_t *ec_major_revision, uint8_t *ec_minor_revision) +{ + *ec_major_revision = 0x0; + *ec_minor_revision = 0x0; +} + /* * System Enclosure or Chassis Types as defined in SMBIOS specification. * The default value is SMBIOS_ENCLOSURE_DESKTOP (0x03) but laptop, diff --git a/src/include/smbios.h b/src/include/smbios.h index 521339e401..8033d6ca98 100644 --- a/src/include/smbios.h +++ b/src/include/smbios.h @@ -54,6 +54,8 @@ const char *smbios_chassis_version(void); const char *smbios_chassis_serial_number(void); const char *smbios_processor_serial_number(void); +void smbios_ec_revision(uint8_t *ec_major_revision, uint8_t *ec_minor_revision); + unsigned int smbios_processor_external_clock(void); unsigned int smbios_processor_characteristics(void); struct cpuid_result; -- cgit v1.2.3