From 328bccc6103b4a61b527b8257768685973d5b333 Mon Sep 17 00:00:00 2001 From: Uwe Hermann Date: Sun, 5 Jul 2009 16:01:57 +0000 Subject: Enable onboard VGA on the MS-6178 (i810 chipset) board (trivial). Tested on hardware with the patch from r4398 and works fine as soon as Linux boots (no VGA in FILO for some reason, will investigate). In order to make the 'i810.vga' VGA blob from the vendor BIOS work you have to make the check for PCI device ID mismatches non-fatal (for now) in the src/devices/pci_rom.c file like this: Index: src/devices/pci_rom.c =================================================================== --- src/devices/pci_rom.c (Revision 4393) +++ src/devices/pci_rom.c (Arbeitskopie) @@ -87,7 +87,7 @@ if (dev->vendor != rom_data->vendor || dev->device != rom_data->device) { printk_err("Device or Vendor ID mismatch Vendor %04x, Device %04x\n", rom_data->vendor, rom_data->device); - return NULL; + // return NULL; } printk_spew("PCI ROM Image, Class Code %04x%02x, Code Type %02x\n", The reason is that the VGA blob thinks the proper VGA device ID is 0x7123 whereas it really is 0x7121 on hardware. There are multiple ways to work around this (there have been many discussions in the past), we'll see which method will be used in future... Note: This has been tested against r4393 only for now to make sure there are no problems because of the recent resource allocator changes, see http://www.coreboot.org/pipermail/coreboot/2009-July/050486.html. Tests with trunk will follow. Signed-off-by: Uwe Hermann Acked-by: Uwe Hermann git-svn-id: svn://svn.coreboot.org/coreboot/trunk@4399 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 --- targets/msi/ms6178/Config.lb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'targets') diff --git a/targets/msi/ms6178/Config.lb b/targets/msi/ms6178/Config.lb index d302f85998..77a6d54935 100644 --- a/targets/msi/ms6178/Config.lb +++ b/targets/msi/ms6178/Config.lb @@ -33,6 +33,7 @@ option CONFIG_MAXIMUM_CONSOLE_LOGLEVEL = 9 option CONFIG_CONSOLE_VGA = 1 option CONFIG_PCI_ROM_RUN = 1 +option CONFIG_VIDEO_MB = 1 romimage "normal" option CONFIG_USE_FALLBACK_IMAGE = 0 @@ -48,5 +49,5 @@ end buildrom ./coreboot.rom CONFIG_ROM_SIZE "normal" "fallback" -# pci_rom i810.vga vendor_id=0x8086 device_id=0x7120 +pci_rom /tmp/i810.vga vendor_id=0x8086 device_id=0x7121 -- cgit v1.2.3