From 675cb9152e6704383cf402c55758ddea2c7a1e05 Mon Sep 17 00:00:00 2001 From: Bill XIE Date: Tue, 12 Nov 2019 01:19:25 +0800 Subject: util/autoport: Stop generate empty h8_mainboard_init_dock(). CB:36385 makes dock init in ramstage fully mainboard-specific, so keeping generating empty h8_mainboard_init_dock() for lenovo EC becomes unnecessary and problematic. Change-Id: I19f57f41403ffd0319cc86f21bec7e142095df83 Signed-off-by: Bill XIE Reviewed-on: https://review.coreboot.org/c/coreboot/+/36752 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- util/autoport/ec_lenovo.go | 14 -------------- util/autoport/readme.md | 6 +++--- 2 files changed, 3 insertions(+), 17 deletions(-) (limited to 'util/autoport') diff --git a/util/autoport/ec_lenovo.go b/util/autoport/ec_lenovo.go index c2dd333c73..9384896dc8 100644 --- a/util/autoport/ec_lenovo.go +++ b/util/autoport/ec_lenovo.go @@ -59,20 +59,6 @@ Method(_PTS,1) si.WriteString("#include \n") - dock := Create(ctx, "dock.c") - defer dock.Close() - - AddRAMStageFile("dock.c", "") - - dock.WriteString( - `#include - -void h8_mainboard_init_dock (void) -{ -/* FIXME: fill this if needed. */ -} -`) - /* FIXME:XX Move this to ec/lenovo. */ smi := Create(ctx, "smihandler.c") defer smi.Close() diff --git a/util/autoport/readme.md b/util/autoport/readme.md index fa349b906f..6d1c64c3eb 100644 --- a/util/autoport/readme.md +++ b/util/autoport/readme.md @@ -407,9 +407,9 @@ Keep `GPE_EC_WAKE` and `GPE_EC_SCI` in sync with `gpi*_routing`. `gpi*_routing` matching `GPE_EC_WAKE` or `GPE_EC_SCI` is set to `2` and all others are absent. -If your dock has LPC wires or needs some special treatement you -need to fill `h8_mainboard_init_dock` and add support code to -DSDT. See the code for `x60`, `x200` or `x201` +If your dock has LPC wires or needs some special treatement you may +need to add codes to initialize the dock and support code to +DSDT. See the `init_dock()` for `x60`, `x200` or `x201`. ## EC (generic laptop) -- cgit v1.2.3