From 68db3a2bdc335519003c7f18ead043d7507718aa Mon Sep 17 00:00:00 2001 From: Carl-Daniel Hailfinger Date: Wed, 14 May 2008 12:03:06 +0000 Subject: Check the JEDEC vendor ID for correct parity. Flash chips which can be detected by JEDEC probe routines all have vendor IDs with correct parity. Use a parity check as additional hint whether a vendor ID makes sense. Note: Device IDs have no parity requirements whatsoever. Signed-off-by: Carl-Daniel Hailfinger Acked-by: Peter Stuge git-svn-id: svn://svn.coreboot.org/coreboot/trunk@3308 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 --- util/flashrom/spi.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'util/flashrom/spi.c') diff --git a/util/flashrom/spi.c b/util/flashrom/spi.c index 5cfc052103..786d555ee9 100644 --- a/util/flashrom/spi.c +++ b/util/flashrom/spi.c @@ -71,8 +71,12 @@ int probe_spi(struct flashchip *flash) uint32_t manuf_id; uint32_t model_id; if (!spi_rdid(readarr)) { + if (!oddparity(readarr[0])) + printf_debug("RDID byte 0 parity violation.\n"); /* Check if this is a continuation vendor ID */ if (readarr[0] == 0x7f) { + if (!oddparity(readarr[1])) + printf_debug("RDID byte 1 parity violation.\n"); manuf_id = (readarr[0] << 8) | readarr[1]; model_id = readarr[2]; } else { -- cgit v1.2.3